From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info
Date: Mon, 18 Nov 2013 13:53:43 +0200 [thread overview]
Message-ID: <1384775449-6693-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1384775449-6693-1-git-send-email-mst@redhat.com>
From: Igor Mammedov <imammedo@redhat.com>
The BIOS that we ship in 1.7 does not use pci info
from host and so far isn't going to use it.
Taking in account problems it caused see 9604f70fdf and
to avoid future incompatibility issues, it's safest to
disable that interface by default for all machine types
including 1.7 as it was never exposed/used by guest.
And properly remove/cleanup it during 1.8 development cycle.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/pc_piix.c | 2 +-
hw/i386/pc_q35.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 4fdb7b6..094c421 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -58,7 +58,7 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 };
static const int ide_irq[MAX_IDE_BUS] = { 14, 15 };
static bool has_pvpanic;
-static bool has_pci_info = true;
+static bool has_pci_info;
static bool has_acpi_build = true;
/* PC hardware initialisation */
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 4c191d3..1af8e2b 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -48,7 +48,7 @@
#define MAX_SATA_PORTS 6
static bool has_pvpanic;
-static bool has_pci_info = true;
+static bool has_pci_info;
static bool has_acpi_build = true;
/* PC hardware initialisation */
--
MST
next prev parent reply other threads:[~2013-11-18 11:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 11:53 [Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8 Michael S. Tsirkin
2013-11-18 11:53 ` Michael S. Tsirkin [this message]
2013-11-26 8:12 ` [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info Laszlo Ersek
2013-11-26 9:10 ` Michael S. Tsirkin
2013-11-26 11:00 ` Gerd Hoffmann
2013-11-26 14:04 ` Michael S. Tsirkin
2013-11-26 14:22 ` Laszlo Ersek
2013-11-26 15:04 ` Michael S. Tsirkin
2013-11-26 15:42 ` Gerd Hoffmann
2013-11-26 15:48 ` Michael S. Tsirkin
2013-11-26 18:26 ` Igor Mammedov
2013-11-27 6:15 ` Michael S. Tsirkin
2013-11-26 15:20 ` Gerd Hoffmann
2013-11-26 15:28 ` Michael S. Tsirkin
2013-11-26 15:59 ` Gerd Hoffmann
2013-11-27 6:20 ` Michael S. Tsirkin
2013-11-26 14:11 ` Laszlo Ersek
2013-11-26 18:58 ` Igor Mammedov
2013-11-18 11:53 ` [Qemu-devel] [PULL for-1.8 2/2] doc: fix hardcoded helper path Michael S. Tsirkin
2013-11-18 15:06 ` [Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8 Eric Blake
2013-11-18 15:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384775449-6693-2-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).