* [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak
@ 2013-11-18 15:10 Stefan Hajnoczi
2013-11-18 15:11 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-11-18 15:10 UTC (permalink / raw)
To: qemu-devel
Cc: Vlad Yasevich, akong, Stefan Hajnoczi, Andreas Faerber,
Anthony Liguori
object_get_canonical_path() returns a string that the caller is
responsible for freeing.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
qom/object.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index b617f26..fc19cf6 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
void object_property_set_link(Object *obj, Object *value,
const char *name, Error **errp)
{
- object_property_set_str(obj, object_get_canonical_path(value),
- name, errp);
+ gchar *path = object_get_canonical_path(value);
+ object_property_set_str(obj, path, name, errp);
+ g_free(path);
}
Object *object_property_get_link(Object *obj, const char *name,
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak
2013-11-18 15:10 [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak Stefan Hajnoczi
@ 2013-11-18 15:11 ` Andreas Färber
2013-11-19 8:49 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2013-11-18 15:11 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Vlad Yasevich, akong, Anthony Liguori
Am 18.11.2013 16:10, schrieb Stefan Hajnoczi:
> object_get_canonical_path() returns a string that the caller is
> responsible for freeing.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
What's the difference to Vlad's v2?
Andreas
> ---
> qom/object.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index b617f26..fc19cf6 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -838,8 +838,9 @@ char *object_property_get_str(Object *obj, const char *name,
> void object_property_set_link(Object *obj, Object *value,
> const char *name, Error **errp)
> {
> - object_property_set_str(obj, object_get_canonical_path(value),
> - name, errp);
> + gchar *path = object_get_canonical_path(value);
> + object_property_set_str(obj, path, name, errp);
> + g_free(path);
> }
>
> Object *object_property_get_link(Object *obj, const char *name,
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak
2013-11-18 15:11 ` Andreas Färber
@ 2013-11-19 8:49 ` Stefan Hajnoczi
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-11-19 8:49 UTC (permalink / raw)
To: Andreas Färber; +Cc: Vlad Yasevich, akong, qemu-devel, Anthony Liguori
On Mon, Nov 18, 2013 at 04:11:43PM +0100, Andreas Färber wrote:
> Am 18.11.2013 16:10, schrieb Stefan Hajnoczi:
> > object_get_canonical_path() returns a string that the caller is
> > responsible for freeing.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> What's the difference to Vlad's v2?
Please ignore this patch, Vlad has already submitted an equivalent patch
which I hadn't seen.
NACK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-19 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-18 15:10 [Qemu-devel] [PATCH for-1.7] qom: fix object_property_set_link() memory leak Stefan Hajnoczi
2013-11-18 15:11 ` Andreas Färber
2013-11-19 8:49 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).