From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViQoR-0001Tc-2X for qemu-devel@nongnu.org; Mon, 18 Nov 2013 10:32:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViQoL-00031G-4G for qemu-devel@nongnu.org; Mon, 18 Nov 2013 10:32:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViQoK-00031B-TC for qemu-devel@nongnu.org; Mon, 18 Nov 2013 10:32:25 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAIFWOOA027751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Nov 2013 10:32:24 -0500 From: Amos Kong Date: Mon, 18 Nov 2013 23:32:17 +0800 Message-Id: <1384788737-6233-1-git-send-email-akong@redhat.com> Subject: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: vyasevic@redhat.com, stefanha@redhat.com, mst@redhat.com object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong --- v2: put gchar *path inside rxfilter_notify_enabled block --- hw/net/virtio-net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 613f144..b75c753 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -200,16 +200,16 @@ static void rxfilter_notify(NetClientState *nc) VirtIONet *n = qemu_get_nic_opaque(nc); if (nc->rxfilter_notify_enabled) { + gchar *path = object_get_canonical_path(OBJECT(n->qdev)); if (n->netclient_name) { event_data = qobject_from_jsonf("{ 'name': %s, 'path': %s }", - n->netclient_name, - object_get_canonical_path(OBJECT(n->qdev))); + n->netclient_name, path); } else { - event_data = qobject_from_jsonf("{ 'path': %s }", - object_get_canonical_path(OBJECT(n->qdev))); + event_data = qobject_from_jsonf("{ 'path': %s }", path); } monitor_protocol_event(QEVENT_NIC_RX_FILTER_CHANGED, event_data); qobject_decref(event_data); + g_free(path); /* disable event notification to avoid events flooding */ nc->rxfilter_notify_enabled = 0; -- 1.8.3.1