From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vioml-0000Gz-QZ for qemu-devel@nongnu.org; Tue, 19 Nov 2013 12:08:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Viomf-0002kD-Kd for qemu-devel@nongnu.org; Tue, 19 Nov 2013 12:08:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Viomf-0002js-Bo for qemu-devel@nongnu.org; Tue, 19 Nov 2013 12:08:17 -0500 From: Paolo Bonzini Date: Tue, 19 Nov 2013 18:07:32 +0100 Message-Id: <1384880863-10434-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1384880863-10434-1-git-send-email-pbonzini@redhat.com> References: <1384880863-10434-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 09/20] block drivers: expose requirement for write same alignment from formats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pl@kamp.de, stefanha@redhat.com This will let misaligned but large requests use zero clusters. This is important because the cluster size is not guest visible. Signed-off-by: Paolo Bonzini --- block/qcow2.c | 1 + block/qed.c | 1 + block/vmdk.c | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 92ed895..9cc247b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -718,6 +718,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, } qemu_opts_del(opts); + bs->bl.write_zeroes_alignment = s->cluster_sectors; if (s->use_lazy_refcounts && s->qcow_version < 3) { error_setg(errp, "Lazy refcounts require a qcow2 image with at least " diff --git a/block/qed.c b/block/qed.c index 1f87420..23247f3 100644 --- a/block/qed.c +++ b/block/qed.c @@ -495,6 +495,7 @@ static int bdrv_qed_open(BlockDriverState *bs, QDict *options, int flags, } } + bs->bl.write_zeroes_alignment = s->header.cluster_size >> BDRV_SECTOR_BITS; s->need_check_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, qed_need_check_timer_cb, s); diff --git a/block/vmdk.c b/block/vmdk.c index 6555663..63ea7ff 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -428,6 +428,10 @@ static int vmdk_add_extent(BlockDriverState *bs, extent->l2_size = l2_size; extent->cluster_sectors = flat ? sectors : cluster_sectors; + if (!flat) { + bs->bl.write_zeroes_alignment = + MAX(bs->bl.write_zeroes_alignment, cluster_sectors); + } if (s->num_extents > 1) { extent->end_sector = (*(extent - 1)).end_sector + extent->sectors; } else { -- 1.8.4.2