qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, WenchaoXia <xiawenc@linux.vnet.ibm.com>,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v3 2/6] qemu-iotests: Honour cache mode in iotests.py
Date: Wed, 20 Nov 2013 15:44:13 +0800	[thread overview]
Message-ID: <1384933457-26953-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1384933457-26953-1-git-send-email-famz@redhat.com>

This will allow overriding cache mode from the "-c mode" option.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/iotests.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index fb10ff4..c84a1a5 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -37,6 +37,7 @@ qemu_args = os.environ.get('QEMU', 'qemu').strip().split(' ')
 imgfmt = os.environ.get('IMGFMT', 'raw')
 imgproto = os.environ.get('IMGPROTO', 'file')
 test_dir = os.environ.get('TEST_DIR', '/var/tmp')
+cachemode = os.environ.get('CACHEMODE')
 
 socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
 
@@ -96,7 +97,7 @@ class VM(object):
         '''Add a virtio-blk drive to the VM'''
         options = ['if=virtio',
                    'format=%s' % imgfmt,
-                   'cache=none',
+                   'cache=%s' % cachemode,
                    'file=%s' % path,
                    'id=drive%d' % self._num_drives]
         if opts:
-- 
1.8.4.2

  parent reply	other threads:[~2013-11-20  7:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20  7:44 [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Fam Zheng
2013-11-20  7:44 ` [Qemu-devel] [PATCH v3 1/6] qemu-iotests: Add "-c <cache-mode>" option Fam Zheng
2013-11-20  7:44 ` Fam Zheng [this message]
2013-11-20  7:44 ` [Qemu-devel] [PATCH v3 3/6] qemu-iotests: Add _supported_cache_modes Fam Zheng
2013-11-21 12:39   ` Stefan Hajnoczi
2013-11-21 12:46     ` Fam Zheng
2013-11-20  7:44 ` [Qemu-devel] [PATCH v3 4/6] qemu-iotests: Change default cache mode to "writeback" Fam Zheng
2013-11-20  7:44 ` [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Force qcow2 in error path test in 048 Fam Zheng
2013-11-21 12:41   ` Stefan Hajnoczi
2013-11-21 12:50     ` Fam Zheng
2013-11-20  7:44 ` [Qemu-devel] [PATCH v3 6/6] qemu-iotests: Clean up spaces in usage output Fam Zheng
2013-11-21 12:43 ` [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Stefan Hajnoczi
2013-11-21 14:16   ` Kevin Wolf
2013-11-22  8:57     ` Stefan Hajnoczi
2013-11-22  9:30       ` Kevin Wolf
2013-11-22 15:51         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384933457-26953-3-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).