From: armbru@redhat.com
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH v2 3/9] ide: Don't block-align IDEState member smart_selftest_data
Date: Wed, 20 Nov 2013 10:55:14 +0100 [thread overview]
Message-ID: <1384941320-30987-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1384941320-30987-1-git-send-email-armbru@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
All uses are simple array subscripts.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/ide/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 0022cc5..2ed7cb8 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2164,8 +2164,7 @@ static void ide_init1(IDEBus *bus, int unit)
s->io_buffer = qemu_memalign(2048, s->io_buffer_total_len);
memset(s->io_buffer, 0, s->io_buffer_total_len);
- s->smart_selftest_data = qemu_blockalign(s->bs, 512);
- memset(s->smart_selftest_data, 0, 512);
+ s->smart_selftest_data = g_malloc0(512);
s->sector_write_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL,
ide_sector_write_timer_cb, s);
--
1.8.1.4
next prev parent reply other threads:[~2013-11-20 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 9:55 [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 1/9] ide: Move IDEDevice pointer from IDEBus to IDEState armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 2/9] ide: Use IDEState member dev for "device connected" test armbru
2013-11-20 9:55 ` armbru [this message]
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 4/9] ide: Drop redundant IDEState member bs armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 5/9] ide: Drop redundant IDEState geometry members armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 6/9] ide: Drop redundant IDEState member version armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 7/9] ide: Drop redundant IDEState member drive_serial_str armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 8/9] ide: Drop redundant IDEState member model armbru
2013-11-20 9:55 ` [Qemu-devel] [PATCH v2 9/9] ide: Drop redundant IDEState member wwn armbru
2013-12-18 14:54 ` [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification Markus Armbruster
2013-12-18 15:38 ` Andreas Färber
2013-12-18 17:05 ` Markus Armbruster
2013-12-19 9:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384941320-30987-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).