From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Vj5Ob-0007KA-QW
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 05:52:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Vj5OV-0001qF-Rd
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 05:52:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Vj5OV-0001pt-Bk
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 05:52:27 -0500
Message-ID: <1384944742.2005.66.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 20 Nov 2013 11:52:22 +0100
In-Reply-To: <1384926761-9962-2-git-send-email-airlied@gmail.com>
References: <1384926761-9962-1-git-send-email-airlied@gmail.com>
	<1384926761-9962-2-git-send-email-airlied@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0
 (v1.2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dave Airlie <airlied@gmail.com>
Cc: qemu-devel@nongnu.org

On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface.

Looks sane on a quick glance.  Didn't look in detail yet.  I would have
suggested to put stuff into structs instead of using global variables,
but I see you do that in patch #5.  I think you can squash the two into
one.

> The biggest changes were in the input handling, where SDL2 has done a major
> overhaul, and I've had to include a generated translation file to get from
> SDL2 codes back to qemu compatible ones. I'm still not sure how the keyboard
> layout code works in qemu, so there may be further work if someone can point
> me a test case that works with SDL1.2 and doesn't with SDL2.

Can you describe what is has changed from sdl 1.2 -> 2.0?

Ideally qemu wants a scancode which it can feed into keyboard emulation.
How that'll get mapped into keysyms is guests bussiness.

When qemu can't get a scancode it will try to translate the keysym back
to a scancode, using a keymap (this is what the -k switch is for).

cheers,
  Gerd