From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vj5w3-0003LE-KG for qemu-devel@nongnu.org; Wed, 20 Nov 2013 06:27:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vj5vx-0004es-Kp for qemu-devel@nongnu.org; Wed, 20 Nov 2013 06:27:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vj5vx-0004eg-CY for qemu-devel@nongnu.org; Wed, 20 Nov 2013 06:27:01 -0500 Message-ID: <1384946817.2005.90.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 20 Nov 2013 12:26:57 +0100 In-Reply-To: <1384926761-9962-7-git-send-email-airlied@gmail.com> References: <1384926761-9962-1-git-send-email-airlied@gmail.com> <1384926761-9962-7-git-send-email-airlied@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/8] virtio-gpu: v0.1 of the virtio based GPU code. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Airlie Cc: qemu-devel@nongnu.org On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: > From: Dave Airlie > > This is the basic virtio-gpu which is > > multi-head capable, > ARGB cursor support, > unaccelerated. I'd like to see an overview on the design of the virtual hardware. What is the purpose of the virtio commands? What are the steps a guest is supposed to do to get something displayed on the screen? > + res = calloc(1, sizeof(struct virtgpu_simple_resource)); > + if (!res) > + return; qemu uses glib memory allocation functions (i.e. g_malloc0 for this one). Also no need to check for NULL. cheers, Gerd