From: Gerd Hoffmann <kraxel@redhat.com>
To: Dave Airlie <airlied@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1
Date: Wed, 20 Nov 2013 13:02:41 +0100 [thread overview]
Message-ID: <1384948961.2005.99.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1384926761-9962-8-git-send-email-airlied@gmail.com>
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This is a virtio-vga device built on top of the virtio-gpu device.
Ah, I see what you use the wrapping for. Hmm. I think you should use a
common base class instead, i.e. something like virtio-gpu-base which
holds all the common stuff. Both virtio-gpu and virtio-vga can use that
as TypeInfo->parent then. This way virtio-vga doesn't have to muck with
virtio-gpu internals. virtio-gpu-base can be tagged as abstract class
(using .abstract = true) so it will not be instantiated directly.
cheers,
Gerd
next prev parent reply other threads:[~2013-11-20 12:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 5:52 [Qemu-devel] [RFC] virtio-gpu and sdl2 so far Dave Airlie
2013-11-20 5:52 ` [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2) Dave Airlie
2013-11-20 10:52 ` Gerd Hoffmann
2013-11-20 5:52 ` [Qemu-devel] [PATCH 2/8] console: add state notifiers for ui<->display Dave Airlie
2013-11-20 11:04 ` Gerd Hoffmann
2013-11-20 5:52 ` [Qemu-devel] [PATCH 3/8] console: add information retrival wrappers Dave Airlie
2013-11-20 11:12 ` Gerd Hoffmann
2013-11-20 5:52 ` [Qemu-devel] [PATCH 4/8] console: add ability to wrap a console Dave Airlie
2013-11-20 5:52 ` [Qemu-devel] [PATCH 5/8] sdl2: update for multihead support Dave Airlie
2013-11-20 5:52 ` [Qemu-devel] [PATCH 6/8] virtio-gpu: v0.1 of the virtio based GPU code Dave Airlie
2013-11-20 11:26 ` Gerd Hoffmann
2013-11-20 5:52 ` [Qemu-devel] [PATCH 7/8] virtio-vga: v1 Dave Airlie
2013-11-20 12:02 ` Gerd Hoffmann [this message]
2013-11-21 3:12 ` Dave Airlie
2013-11-21 6:17 ` Paolo Bonzini
2013-11-21 11:06 ` Gerd Hoffmann
2013-12-06 5:24 ` Dave Airlie
2013-12-06 8:24 ` Gerd Hoffmann
2013-12-06 8:58 ` Dave Airlie
2014-01-07 23:35 ` Dave Airlie
2014-01-13 8:01 ` Gerd Hoffmann
2013-11-20 5:52 ` [Qemu-devel] [PATCH 8/8] HACK: just to make things start easier with libvirt Dave Airlie
-- strict thread matches above, loose matches on Subject: below --
2013-12-10 4:05 [Qemu-devel] [RFC] sdl2 + virtio-gpu repost Dave Airlie
2013-12-10 4:05 ` [Qemu-devel] [PATCH 7/8] virtio-vga: v1 Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384948961.2005.99.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).