From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vj6bG-0001gx-Aj for qemu-devel@nongnu.org; Wed, 20 Nov 2013 07:09:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vj6b9-0007xq-Bu for qemu-devel@nongnu.org; Wed, 20 Nov 2013 07:09:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vj6b9-0007xl-45 for qemu-devel@nongnu.org; Wed, 20 Nov 2013 07:09:35 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAKC9YeU001239 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Nov 2013 07:09:34 -0500 From: Kevin Wolf Date: Wed, 20 Nov 2013 13:09:20 +0100 Message-Id: <1384949361-19143-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1384949361-19143-1-git-send-email-kwolf@redhat.com> References: <1384949361-19143-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] qdict: Fix memory leak in qdict_do_flatten() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, lersek@redhat.com, stefanha@redhat.com Reported-by: Laszlo Ersek Signed-off-by: Kevin Wolf --- qobject/qdict.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 0f3e0a6..60d6cd5 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -481,7 +481,7 @@ static void qdict_do_flatten(QDict *qdict, QDict *target, const char *prefix) { QObject *value; const QDictEntry *entry, *next; - const char *new_key; + char *new_key; bool delete; entry = qdict_first(qdict); @@ -506,6 +506,8 @@ static void qdict_do_flatten(QDict *qdict, QDict *target, const char *prefix) delete = true; } + g_free(new_key); + if (delete) { qdict_del(qdict, entry->key); -- 1.8.1.4