[Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

[Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

[Stefan Hajnoczi]

Hi Gerd,
make check is failing on kraxel_rhel61 due to the following:

ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1)

http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782

Can you investigate?  Perhaps there are stale files.

(There is a separate issue where make check is attempting to open an
X11 display.  This has been fixed in the latest block pull request and
will soon be resolved in the buildbot.)

Thanks,
Stefan

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

[Gerd Hoffmann]

On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote:
> Hi Gerd,
> make check is failing on kraxel_rhel61 due to the following:
> 
> ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1)
> 
> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782
> 
> Can you investigate?  Perhaps there are stale files.

Probably, that was the case when it happened last time.

Yep, there are tons of /tmp/qtest-$number.{qmp,sock} files.  Cleared
now.

Where do they come from?  Running "make check" manually does _not_ leave
stale files in /tmp for me.  Hmm.  What is going on?

cheers,
  Gerd

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

[Stefan Hajnoczi]

On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote:
> On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote:
> > Hi Gerd,
> > make check is failing on kraxel_rhel61 due to the following:
> > 
> > ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1)
> > 
> > http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782
> > 
> > Can you investigate?  Perhaps there are stale files.
> 
> Probably, that was the case when it happened last time.
> 
> Yep, there are tons of /tmp/qtest-$number.{qmp,sock} files.  Cleared
> now.
> 
> Where do they come from?  Running "make check" manually does _not_ leave
> stale files in /tmp for me.  Hmm.  What is going on?

Quite probably a resource leak in libqtest.  But I'm not sure which
scenario causes them to accumulate - maybe when a test assertion fails?

Stefan

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

[Andreas Färber]

Am 20.11.2013 16:16, schrieb Stefan Hajnoczi:
> On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote:
>> On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote:
>>> Hi Gerd,
>>> make check is failing on kraxel_rhel61 due to the following:
>>>
>>> ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1)
>>>
>>> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782
>>>
>>> Can you investigate?  Perhaps there are stale files.
>>
>> Probably, that was the case when it happened last time.
>>
>> Yep, there are tons of /tmp/qtest-$number.{qmp,sock} files.  Cleared
>> now.
>>
>> Where do they come from?  Running "make check" manually does _not_ leave
>> stale files in /tmp for me.  Hmm.  What is going on?
> 
> Quite probably a resource leak in libqtest.  But I'm not sure which
> scenario causes them to accumulate - maybe when a test assertion fails?

Yes, that's when it happens. I had wondered if adding some atexit() hook
might be a solution but never found time to try that out.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

[Stefan Hajnoczi]

On Wed, Nov 20, 2013 at 05:05:46PM +0100, Andreas Färber wrote:
> Am 20.11.2013 16:16, schrieb Stefan Hajnoczi:
> > On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote:
> >> On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote:
> >>> Hi Gerd,
> >>> make check is failing on kraxel_rhel61 due to the following:
> >>>
> >>> ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1)
> >>>
> >>> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782
> >>>
> >>> Can you investigate?  Perhaps there are stale files.
> >>
> >> Probably, that was the case when it happened last time.
> >>
> >> Yep, there are tons of /tmp/qtest-$number.{qmp,sock} files.  Cleared
> >> now.
> >>
> >> Where do they come from?  Running "make check" manually does _not_ leave
> >> stale files in /tmp for me.  Hmm.  What is going on?
> > 
> > Quite probably a resource leak in libqtest.  But I'm not sure which
> > scenario causes them to accumulate - maybe when a test assertion fails?
> 
> Yes, that's when it happens. I had wondered if adding some atexit() hook
> might be a solution but never found time to try that out.

Okay.  I'll investigate.

Stefan