From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, stefanha@redhat.com, mst@redhat.com,
chegu_vinod@hp.com, stefanb@linux.vnet.ibm.com, mjt@tls.msk.ru,
mdroth@linux.vnet.ibm.com, armbru@redhat.com,
vasilis.liaskovitis@profitbricks.com, quintela@redhat.com,
kraxel@redhat.com, aliguori@amazon.com, hutao@cn.fujitsu.com,
pbonzini@redhat.com, marcel.a@redhat.com, lcapitulino@redhat.com,
afaerber@suse.de
Subject: [Qemu-devel] [PATCH 15/27] acpi: piix4: add memory-hotplug-io-base property to piix4_pm
Date: Thu, 21 Nov 2013 03:38:36 +0100 [thread overview]
Message-ID: <1385001528-12003-16-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1385001528-12003-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/piix4.c | 14 +++++++++++++-
include/hw/acpi/acpi.h | 2 ++
2 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index e0d9270..a835981 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -18,6 +18,7 @@
* Contributions after 2012-01-13 are licensed under the terms of the
* GNU GPL, version 2 or (at your option) any later version.
*/
+#include "qapi/visitor.h"
#include "hw/hw.h"
#include "hw/i386/pc.h"
#include "hw/isa/apm.h"
@@ -757,6 +758,14 @@ int piix4_mem_hotplug(DeviceState *hotplug_dev, DeviceState *dev,
static int piix4_device_hotplug(DeviceState *qdev, DeviceState *dev,
HotplugState state);
+static void piix4_get_mem_io_base(Object *obj, Visitor *v, void *opaque,
+ const char *name, Error **errp)
+{
+ PIIX4PMState *s = PIIX4_PM(obj);
+
+ visit_type_uint16(v, &s->gpe_mem.port, name, errp);
+}
+
static void piix4_acpi_system_hot_add_init(MemoryRegion *parent,
PCIBus *bus, PIIX4PMState *s)
{
@@ -789,8 +798,11 @@ static void piix4_acpi_system_hot_add_init(MemoryRegion *parent,
s->cpu_added_notifier.notify = piix4_cpu_added_req;
qemu_register_cpu_added_notifier(&s->cpu_added_notifier);
+ s->gpe_mem.port = ACPI_MEMORY_HOTPLUG_BASE;
+ object_property_add(OBJECT(s), ACPI_MEMORY_HOTPLUG_IO_BASE_PROP, "int",
+ piix4_get_mem_io_base, NULL, NULL, NULL, NULL);
acpi_memory_hotplug_init(OBJECT(s), &s->io_mem, &s->gpe_mem);
- memory_region_add_subregion(parent, ACPI_MEMORY_HOTPLUG_BASE, &s->io_mem);
+ memory_region_add_subregion(parent, s->gpe_mem.port, &s->io_mem);
}
static void enable_device(PIIX4PMState *s, int slot)
diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
index e5717df..95c608f 100644
--- a/include/hw/acpi/acpi.h
+++ b/include/hw/acpi/acpi.h
@@ -170,6 +170,7 @@ void acpi_update_sci(ACPIREGS *acpi_regs, qemu_irq irq, uint32_t gpe0_sts_mask);
#define ACPI_MEMORY_HOTPLUG_IO_LEN 24
#define ACPI_MEMORY_HOTPLUG_BASE 0x0a00
+#define ACPI_MEMORY_HOTPLUG_IO_BASE_PROP "memory-hotplug-io-base"
#define ACPI_MEMORY_HOTPLUG_STATUS 8
@@ -182,6 +183,7 @@ typedef struct MemStatus {
} MemStatus;
typedef struct MemHotplugState {
+ uint16_t port;
uint32_t selector;
uint32_t dev_count;
MemStatus *devs;
--
1.7.1
next prev parent reply other threads:[~2013-11-21 2:41 UTC|newest]
Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 2:38 [Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 01/27] acpi: factor out common pm_update_sci() into acpi core Igor Mammedov
2013-12-05 12:37 ` Michael S. Tsirkin
2013-12-05 15:11 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 02/27] rename pci_hotplug_fn to hotplug_fn and make it available for other devices Igor Mammedov
2013-11-25 12:49 ` Paolo Bonzini
2013-11-25 13:11 ` Paolo Bonzini
2013-11-25 15:57 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 03/27] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS Igor Mammedov
2013-12-19 14:35 ` Michael S. Tsirkin
2013-12-20 12:48 ` Igor Mammedov
2013-12-22 11:20 ` Michael S. Tsirkin
2013-11-21 2:38 ` [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse() Igor Mammedov
2013-11-21 6:01 ` Li Guang
2013-11-21 13:45 ` Igor Mammedov
2013-11-21 10:12 ` Markus Armbruster
2013-11-26 13:17 ` Igor Mammedov
2013-11-26 14:49 ` Markus Armbruster
2013-11-26 16:55 ` Igor Mammedov
2013-11-27 14:35 ` Markus Armbruster
2013-11-27 15:28 ` Igor Mammedov
2013-11-27 17:31 ` Markus Armbruster
2013-11-27 0:27 ` [Qemu-devel] [PATCH 04/28] vl: convert -m to QemuOpts Igor Mammedov
2013-11-27 0:27 ` [Qemu-devel] [PATCH 05/28] vl.c: extend -m option to support options for memory hotplug Igor Mammedov
2013-12-10 7:23 ` [Qemu-devel] [PATCH 04/28] vl: convert -m to QemuOpts Paolo Bonzini
2013-12-10 10:53 ` Igor Mammedov
2013-11-25 12:51 ` [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse() Paolo Bonzini
2013-11-27 0:32 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor Igor Mammedov
2013-11-21 10:15 ` Markus Armbruster
2013-11-25 15:36 ` Igor Mammedov
2013-11-25 16:04 ` Michael S. Tsirkin
2013-11-25 16:32 ` Paolo Bonzini
2013-11-25 16:43 ` Eric Blake
2013-11-25 17:01 ` Paolo Bonzini
2013-11-27 14:15 ` Markus Armbruster
2013-11-27 15:17 ` Paolo Bonzini
2013-11-27 17:02 ` Markus Armbruster
2013-11-27 17:10 ` Paolo Bonzini
2013-12-19 14:40 ` Michael S. Tsirkin
2013-12-19 15:14 ` Markus Armbruster
2013-12-19 15:32 ` Michael S. Tsirkin
2013-12-19 15:31 ` Paolo Bonzini
2013-12-19 15:40 ` Michael S. Tsirkin
2013-12-19 15:46 ` Paolo Bonzini
2013-11-21 2:38 ` [Qemu-devel] [PATCH 06/27] get reference to /backend container via qemu_get_backend() Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure Igor Mammedov
2013-11-25 12:54 ` Paolo Bonzini
2013-11-25 16:01 ` Igor Mammedov
2013-11-25 16:09 ` Paolo Bonzini
2013-11-27 14:37 ` Igor Mammedov
2013-11-27 15:21 ` Paolo Bonzini
2013-11-27 15:57 ` Igor Mammedov
2013-11-27 15:25 ` Eric Blake
2013-11-27 16:09 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 08/27] dimm: implement dimm device abstraction Igor Mammedov
2013-11-25 12:57 ` Paolo Bonzini
2013-11-25 15:10 ` Igor Mammedov
2013-11-25 15:16 ` Paolo Bonzini
2013-11-21 2:38 ` [Qemu-devel] [PATCH 09/27] dimm: map DimmDevice into DimBus provided address space Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 10/27] dimm: add busy slot check and slot auto-allocation Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 11/27] dimm: add busy address check and address auto-allocation Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 12/27] dimm: add hotplug callback to DimmBus Igor Mammedov
2013-11-25 13:01 ` Paolo Bonzini
2013-11-25 14:40 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation Igor Mammedov
2013-11-21 9:42 ` Michael S. Tsirkin
2013-11-21 14:21 ` Igor Mammedov
2013-11-21 14:38 ` Michael S. Tsirkin
2013-11-22 17:14 ` Igor Mammedov
2013-11-24 10:58 ` Michael S. Tsirkin
2013-11-25 7:27 ` Markus Armbruster
2013-11-25 13:45 ` Paolo Bonzini
2013-11-25 14:18 ` Igor Mammedov
2013-11-25 14:31 ` Paolo Bonzini
2013-11-25 14:57 ` Igor Mammedov
2013-11-25 13:56 ` Igor Mammedov
2013-11-27 17:59 ` Eric Blake
2013-11-21 2:38 ` [Qemu-devel] [PATCH 14/27] acpi: initialize memory hotplug ACPI PIIX4 hardware Igor Mammedov
2013-11-21 2:38 ` Igor Mammedov [this message]
2013-11-21 2:38 ` [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE Igor Mammedov
2013-11-21 7:14 ` Michael S. Tsirkin
2013-11-21 8:12 ` Hu Tao
2013-11-21 8:18 ` Li Guang
2013-11-21 8:29 ` Michael S. Tsirkin
2013-11-21 8:32 ` Li Guang
2013-11-21 9:43 ` Michael S. Tsirkin
2013-11-22 0:57 ` Li Guang
2013-11-25 11:13 ` Igor Mammedov
2013-11-26 0:29 ` Li Guang
2013-11-26 22:36 ` Igor Mammedov
2013-11-27 0:15 ` Li Guang
2013-11-27 0:57 ` Igor Mammedov
2013-11-27 1:48 ` Li Guang
2013-11-27 9:43 ` Paolo Bonzini
2013-11-21 13:19 ` Igor Mammedov
2013-11-22 1:03 ` Li Guang
2013-11-21 8:26 ` Michael S. Tsirkin
2013-11-21 8:28 ` Hu Tao
2013-11-21 13:31 ` Igor Mammedov
2013-11-21 13:21 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 17/27] acpi: initialize memory hotplug ACPI ICH9 hardware Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 18/27] acpi: ich9: add memory-hotplug-io-base property to ich9_pm Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 19/27] acpi: piix4/ich9: add optional vmstate field for MemHotplugState migration Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 20/27] pc: piix: make PCII440FXState type public Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine Igor Mammedov
2013-11-21 5:48 ` Li Guang
2013-11-21 14:13 ` Andreas Färber
2013-11-21 14:34 ` Igor Mammedov
2013-11-21 14:39 ` Michael S. Tsirkin
2013-11-21 16:09 ` Andreas Färber
2013-11-21 16:17 ` Michael S. Tsirkin
2013-11-25 10:41 ` Igor Mammedov
2013-11-25 17:00 ` Andreas Färber
2013-11-26 20:26 ` Igor Mammedov
2013-11-22 14:23 ` Gerd Hoffmann
2013-11-25 11:00 ` Igor Mammedov
2013-11-25 11:39 ` Gerd Hoffmann
2013-11-25 13:34 ` Igor Mammedov
2013-11-25 13:35 ` Paolo Bonzini
2013-11-25 14:24 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 22/27] pc: add memory hotplug Q35 machine Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface Igor Mammedov
2013-11-21 9:37 ` Michael S. Tsirkin
2013-11-25 14:39 ` Igor Mammedov
2013-12-16 19:50 ` Michael S. Tsirkin
2013-12-16 21:42 ` Igor Mammedov
2013-11-25 13:42 ` Paolo Bonzini
2013-11-25 14:26 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 24/27] pc: ACPI BIOS: add ssdt-mem.hex.generated and update ssdt-misc.hex.generated Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 25/27] pc: ACPI BIOS: use enum for defining memory affinity flags Igor Mammedov
2013-11-21 7:20 ` Michael S. Tsirkin
2013-11-25 10:11 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 26/27] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole Igor Mammedov
2013-11-21 7:18 ` Michael S. Tsirkin
2013-11-25 10:11 ` Igor Mammedov
2013-11-21 2:38 ` [Qemu-devel] [PATCH 27/27] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines Igor Mammedov
2013-11-21 6:20 ` [Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug Michael S. Tsirkin
2013-11-21 13:39 ` Igor Mammedov
2013-11-21 13:43 ` Michael S. Tsirkin
2013-11-21 14:37 ` Igor Mammedov
2013-11-21 14:45 ` Michael S. Tsirkin
2013-11-25 10:09 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385001528-12003-16-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=hutao@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).