From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 4/4] spapr-pci: converts fprintf to error_report
Date: Thu, 21 Nov 2013 15:08:58 +1100 [thread overview]
Message-ID: <1385006938-32515-5-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1385006938-32515-1-git-send-email-aik@ozlabs.ru>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/ppc/spapr_pci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 963841c..d102d82 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -293,7 +293,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr,
ret_intr_type = RTAS_TYPE_MSIX;
break;
default:
- fprintf(stderr, "rtas_ibm_change_msi(%u) is not implemented\n", func);
+ error_report("rtas_ibm_change_msi(%u) is not implemented", func);
rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);
return;
}
@@ -327,7 +327,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr,
/* Find a device number in the map to add or reuse the existing one */
ndev = spapr_msicfg_find(phb, config_addr, true);
if (ndev >= SPAPR_MSIX_MAX_DEVS || ndev < 0) {
- fprintf(stderr, "No free entry for a new MSI device\n");
+ error_report("No free entry for a new MSI device");
rtas_st(rets, 0, RTAS_OUT_HW_ERROR);
return;
}
@@ -336,7 +336,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr,
/* Check if there is an old config and MSI number has not changed */
if (phb->msi_table[ndev].nvec && (req_num != phb->msi_table[ndev].nvec)) {
/* Unexpected behaviour */
- fprintf(stderr, "Cannot reuse MSI config for device#%d", ndev);
+ error_report("Cannot reuse MSI config for device#%d", ndev);
rtas_st(rets, 0, RTAS_OUT_HW_ERROR);
return;
}
@@ -346,7 +346,7 @@ static void rtas_ibm_change_msi(PowerPCCPU *cpu, sPAPREnvironment *spapr,
irq = spapr_allocate_irq_block(req_num, false,
ret_intr_type == RTAS_TYPE_MSI);
if (irq < 0) {
- fprintf(stderr, "Cannot allocate MSIs for device#%d", ndev);
+ error_report("Cannot allocate MSIs for device#%d", ndev);
rtas_st(rets, 0, RTAS_OUT_HW_ERROR);
return;
}
--
1.8.4.rc4
next prev parent reply other threads:[~2013-11-21 4:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 4:08 [Qemu-devel] [PATCH 0/4] spapr-pci: prepare for vfio Alexey Kardashevskiy
2013-11-21 4:08 ` [Qemu-devel] [PATCH 1/4] spapr-pci: convert init() callback to realize() Alexey Kardashevskiy
2014-03-12 13:20 ` [Qemu-devel] " Mike Day
2014-03-12 13:56 ` Mike Day
2014-03-12 23:25 ` Alexey Kardashevskiy
2014-03-13 1:45 ` [Qemu-devel] [PATCH 1/4] " Andreas Färber
2013-11-21 4:08 ` [Qemu-devel] [PATCH 2/4] spapr-pci: introduce a finish_realize() callback Alexey Kardashevskiy
2014-03-12 15:30 ` [Qemu-devel] " Mike Day
2014-03-13 1:56 ` [Qemu-devel] [PATCH 2/4] " Andreas Färber
2014-03-13 7:29 ` Alexey Kardashevskiy
2013-11-21 4:08 ` [Qemu-devel] [PATCH 3/4] spapr-pci: add spapr_pci trace Alexey Kardashevskiy
2014-03-13 1:46 ` Andreas Färber
2014-03-13 7:37 ` Alexey Kardashevskiy
2013-11-21 4:08 ` Alexey Kardashevskiy [this message]
2014-03-12 15:41 ` [Qemu-devel] spapr-pci: converts fprintf to error_report Mike Day
2014-03-13 1:50 ` [Qemu-devel] [PATCH 4/4] " Andreas Färber
2013-12-05 9:39 ` [Qemu-devel] [PATCH 0/4] spapr-pci: prepare for vfio Alexey Kardashevskiy
2013-12-20 2:47 ` Alexey Kardashevskiy
2014-01-15 7:10 ` Alexey Kardashevskiy
2014-02-12 11:44 ` Alexey Kardashevskiy
2014-03-12 3:33 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385006938-32515-5-git-send-email-aik@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).