From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, anthony@codemonkey.ws
Subject: [Qemu-devel] [PATCH 1.7 1/2] rng-egd: remove redundant free
Date: Thu, 21 Nov 2013 16:42:50 +0800 [thread overview]
Message-ID: <1385023371-8198-2-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1385023371-8198-1-git-send-email-akong@redhat.com>
We didn't set default chr_name, the free is redundant.
Signed-off-by: Amos Kong <akong@redhat.com>
---
backends/rng-egd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/backends/rng-egd.c b/backends/rng-egd.c
index 9e5a536..6f56f9e 100644
--- a/backends/rng-egd.c
+++ b/backends/rng-egd.c
@@ -167,7 +167,6 @@ static void rng_egd_set_chardev(Object *obj, const char *value, Error **errp)
if (b->opened) {
error_set(errp, QERR_PERMISSION_DENIED);
} else {
- g_free(s->chr_name);
s->chr_name = g_strdup(value);
}
}
--
1.8.3.1
next prev parent reply other threads:[~2013-11-21 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 8:42 [Qemu-devel] [PATCH 1.7 0/2] fix rng-egd backend Amos Kong
2013-11-21 8:42 ` Amos Kong [this message]
2013-11-21 8:42 ` [Qemu-devel] [PATCH 1.7 2/2] rng-egd: offset the point when repeatedly read from the buffer Amos Kong
2013-11-21 15:26 ` [Qemu-devel] [PATCH 1.7 0/2] fix rng-egd backend Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385023371-8198-2-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).