From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjPqw-0001bh-Mi for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:43:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjPqq-0003UX-Km for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:43:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjPqq-0003UL-Ca for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:43:04 -0500 From: Amos Kong Date: Thu, 21 Nov 2013 16:42:50 +0800 Message-Id: <1385023371-8198-2-git-send-email-akong@redhat.com> In-Reply-To: <1385023371-8198-1-git-send-email-akong@redhat.com> References: <1385023371-8198-1-git-send-email-akong@redhat.com> Subject: [Qemu-devel] [PATCH 1.7 1/2] rng-egd: remove redundant free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, anthony@codemonkey.ws We didn't set default chr_name, the free is redundant. Signed-off-by: Amos Kong --- backends/rng-egd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 9e5a536..6f56f9e 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -167,7 +167,6 @@ static void rng_egd_set_chardev(Object *obj, const char *value, Error **errp) if (b->opened) { error_set(errp, QERR_PERMISSION_DENIED); } else { - g_free(s->chr_name); s->chr_name = g_strdup(value); } } -- 1.8.3.1