From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjPr8-0001qT-8p for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:43:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjPr3-0003Vo-3n for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:43:22 -0500 From: Amos Kong Date: Thu, 21 Nov 2013 16:42:51 +0800 Message-Id: <1385023371-8198-3-git-send-email-akong@redhat.com> In-Reply-To: <1385023371-8198-1-git-send-email-akong@redhat.com> References: <1385023371-8198-1-git-send-email-akong@redhat.com> Subject: [Qemu-devel] [PATCH 1.7 2/2] rng-egd: offset the point when repeatedly read from the buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, qemu-stable@nongnu.org, anthony@codemonkey.ws The buffer content might be read out more than once, currently we just repeatedly read the first data block, buffer offset is missing. Cc: qemu-stable@nongnu.org Signed-off-by: Amos Kong --- backends/rng-egd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 6f56f9e..25bb3b4 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -91,12 +91,14 @@ static int rng_egd_chr_can_read(void *opaque) static void rng_egd_chr_read(void *opaque, const uint8_t *buf, int size) { RngEgd *s = RNG_EGD(opaque); + size_t buf_offset = 0; while (size > 0 && s->requests) { RngRequest *req = s->requests->data; int len = MIN(size, req->size - req->offset); - memcpy(req->data + req->offset, buf, len); + memcpy(req->data + req->offset, buf + buf_offset, len); + buf_offset += len; req->offset += len; size -= len; -- 1.8.3.1