From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjPzj-0005qr-22 for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:52:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjPzd-0006Kb-4h for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:52:14 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:52272 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjPzc-0006KI-QR for qemu-devel@nongnu.org; Thu, 21 Nov 2013 03:52:09 -0500 From: Peter Lieven Date: Thu, 21 Nov 2013 09:51:16 +0100 Message-Id: <1385023877-26524-6-git-send-email-pl@kamp.de> In-Reply-To: <1385023877-26524-1-git-send-email-pl@kamp.de> References: <1385023877-26524-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv2 5/6] ui/vnc: optimize setting in vnc_dpy_update() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: corentincj@iksaif.net, Peter Lieven , hengqing.hu@gmail.com, anthony@codemonkey.ws Signed-off-by: Peter Lieven --- ui/vnc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 3bbf2af..5134456 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -430,7 +430,6 @@ static int vnc_refresh_server_surface(VncDisplay *vd); static void vnc_dpy_update(DisplayChangeListener *dcl, int x, int y, int w, int h) { - int i; VncDisplay *vd = container_of(dcl, VncDisplay, dcl); struct VncSurface *s = &vd->guest; int width = surface_width(vd->ds); @@ -451,9 +450,7 @@ static void vnc_dpy_update(DisplayChangeListener *dcl, h = MIN(h, height); for (; y < h; y++) { - for (i = 0; i < w; i += VNC_DIRTY_PIXELS_PER_BIT) { - set_bit((x + i) / VNC_DIRTY_PIXELS_PER_BIT, s->dirty[y]); - } + bitmap_set(s->dirty[y], x / VNC_DIRTY_PIXELS_PER_BIT, w / VNC_DIRTY_PIXELS_PER_BIT); } } -- 1.7.9.5