From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Andreas Faerber <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets
Date: Thu, 21 Nov 2013 12:03:53 +0100 [thread overview]
Message-ID: <1385031835-4472-1-git-send-email-stefanha@redhat.com> (raw)
GLib uses abort(3) to exit failed test cases. As a result, the pid file and
UNIX domain sockets for a running test are leaked upon failure.
Since abort(3) does not call atexit(3) handler functions, we could set up a
SIGABRT handler that performs cleanup. But there are other conditions where
processes die, like SIGSEGV or SIGBUS.
Let's unlink pid files and UNIX domain sockets as soon as the QEMU process has
initialized and connections have been made. This eliminates the possibility of
leaking these files.
Note that the actual QEMU process is orphaned when a test case fails. This
series does not fix that problem.
Stefan Hajnoczi (2):
qtest: unlink QEMU pid file after startup
qtest: unlink UNIX domain sockets after connecting
tests/libqtest.c | 45 +++++++++++++++++++++++----------------------
1 file changed, 23 insertions(+), 22 deletions(-)
--
1.8.4.2
next reply other threads:[~2013-11-21 11:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 11:03 Stefan Hajnoczi [this message]
2013-11-21 11:03 ` [Qemu-devel] [PATCH 1/2] qtest: unlink QEMU pid file after startup Stefan Hajnoczi
2013-12-06 10:59 ` Markus Armbruster
2013-11-21 11:03 ` [Qemu-devel] [PATCH 2/2] qtest: unlink UNIX domain sockets after connecting Stefan Hajnoczi
2013-12-05 15:57 ` [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets Stefan Hajnoczi
2013-12-06 11:07 ` Markus Armbruster
2014-01-31 0:07 ` Peter Maydell
2014-01-31 10:56 ` Stefan Hajnoczi
2014-02-03 9:00 ` Gerd Hoffmann
2014-02-03 9:54 ` Stefan Hajnoczi
2014-02-03 10:30 ` Peter Maydell
2014-02-03 15:22 ` Stefan Hajnoczi
2014-02-03 11:10 ` Andreas Färber
2014-02-03 11:24 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385031835-4472-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).