From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: drjones@redhat.com, ehabkost@redhat.com, lersek@redhat.com,
hutao@cn.fujitsu.com, mtosatti@redhat.com,
peter.huangpeng@huawei.com, lcapitulino@redhat.com,
bsd@redhat.com, anthony@codemonkey.ws, y-goto@jp.fujitsu.com,
pbonzini@redhat.com, afaerber@suse.de, gaowanlong@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH V16 08/11] NUMA: parse guest numa nodes memory policy
Date: Fri, 22 Nov 2013 10:08:35 +0800 [thread overview]
Message-ID: <1385086118-11699-10-git-send-email-gaowanlong@cn.fujitsu.com> (raw)
In-Reply-To: <1385086118-11699-1-git-send-email-gaowanlong@cn.fujitsu.com>
The memory policy setting format is like:
policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N
And we are adding this setting as a suboption of "-numa mem,",
the memory policy then can be set like following:
-numa node,nodeid=0,cpus=0 \
-numa node,nodeid=1,cpus=1 \
-numa mem,nodeid=0,size=1G,policy=membind,host-nodes=0-1 \
-numa mem,nodeid=1,size=1G,policy=interleave,relative=true,host-nodes=1
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
include/sysemu/sysemu.h | 3 +++
numa.c | 18 ++++++++++++++++++
qapi-schema.json | 33 +++++++++++++++++++++++++++++++--
vl.c | 3 +++
4 files changed, 55 insertions(+), 2 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 807619e..82f1447 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -139,6 +139,9 @@ extern int nb_numa_mem_nodes;
typedef struct node_info {
uint64_t node_mem;
DECLARE_BITMAP(node_cpu, MAX_CPUMASK_BITS);
+ DECLARE_BITMAP(host_mem, MAX_NODES);
+ NumaNodePolicy policy;
+ bool relative;
} NodeInfo;
extern NodeInfo numa_info[MAX_NODES];
void set_numa_nodes(void);
diff --git a/numa.c b/numa.c
index c676c5e..da4dbbd 100644
--- a/numa.c
+++ b/numa.c
@@ -78,6 +78,7 @@ static int numa_mem_parse(NumaMemOptions *opts)
{
uint16_t nodenr;
uint64_t mem_size;
+ uint16List *nodes;
if (opts->has_nodeid) {
nodenr = opts->nodeid;
@@ -96,6 +97,23 @@ static int numa_mem_parse(NumaMemOptions *opts)
numa_info[nodenr].node_mem = mem_size;
}
+ if (opts->has_policy) {
+ numa_info[nodenr].policy = opts->policy;
+ }
+
+ if (opts->has_relative) {
+ numa_info[nodenr].relative = opts->relative;
+ }
+
+ for (nodes = opts->host_nodes; nodes; nodes = nodes->next) {
+ if (nodes->value > MAX_NODES) {
+ fprintf(stderr, "qemu: node number %" PRIu16 " is bigger than %d\n",
+ nodes->value, MAX_NODES);
+ continue;
+ }
+ bitmap_set(numa_info[nodenr].host_mem, nodes->value, 1);
+ }
+
return 0;
}
diff --git a/qapi-schema.json b/qapi-schema.json
index 1043e57..c0dad81 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4246,6 +4246,26 @@
'*mem': 'str' }}
##
+# @NumaNodePolicy
+#
+# NUMA node policy types
+#
+# @default: restore default policy, remove any nondefault policy
+#
+# @preferred: set the preferred node for allocation
+#
+# @membind: a strict policy that restricts memory allocation to the
+# nodes specified
+#
+# @interleave: the page allocations is interleaved across the set
+# of nodes specified
+#
+# Since 1.7
+##
+{ 'enum': 'NumaNodePolicy',
+ 'data': [ 'default', 'preferred', 'membind', 'interleave' ] }
+
+##
# @NumaMemOptions
#
# Set memory information of guest NUMA node. (for OptsVisitor)
@@ -4254,9 +4274,18 @@
#
# @size: #optional memory size of this node
#
+# @policy: #optional memory policy of this node
+#
+# @relative: #optional if the nodes specified are relative
+#
+# @host-nodes: #optional host nodes for its memory policy
+#
# Since 1.7
##
{ 'type': 'NumaMemOptions',
'data': {
- '*nodeid': 'uint16',
- '*size': 'size' }}
+ '*nodeid': 'uint16',
+ '*size': 'size',
+ '*policy': 'NumaNodePolicy',
+ '*relative': 'bool',
+ '*host-nodes': ['uint16'] }}
diff --git a/vl.c b/vl.c
index 064b821..95d03f5 100644
--- a/vl.c
+++ b/vl.c
@@ -2815,6 +2815,9 @@ int main(int argc, char **argv, char **envp)
for (i = 0; i < MAX_NODES; i++) {
numa_info[i].node_mem = 0;
bitmap_zero(numa_info[i].node_cpu, MAX_CPUMASK_BITS);
+ bitmap_zero(numa_info[i].host_mem, MAX_NODES);
+ numa_info[i].policy = NUMA_NODE_POLICY_DEFAULT;
+ numa_info[i].relative = false;
}
nb_numa_nodes = 0;
--
1.8.5.rc3
next prev parent reply other threads:[~2013-11-22 2:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 2:08 [Qemu-devel] [PATCH V16 00/11] Add support for binding guest numa nodes to host numa nodes Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH] fixup Wanlong Gao
2013-11-22 2:10 ` Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 01/11] NUMA: move numa related code to new file numa.c Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 02/11] NUMA: check if the total numa memory size is equal to ram_size Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 03/11] NUMA: Add numa_info structure to contain numa nodes info Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 04/11] NUMA: convert -numa option to use OptsVisitor Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 05/11] NUMA: introduce NumaMemOptions Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 06/11] NUMA: add "-numa mem," options Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 07/11] NUMA: expand MAX_NODES from 64 to 128 Wanlong Gao
2013-11-22 2:08 ` Wanlong Gao [this message]
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 09/11] NUMA: set guest numa nodes memory policy Wanlong Gao
2013-11-27 14:35 ` Paolo Bonzini
2013-11-27 15:09 ` Wanlong Gao
2013-11-27 16:19 ` Andrew Jones
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 10/11] NUMA: add qmp command query-numa Wanlong Gao
2013-11-22 2:08 ` [Qemu-devel] [PATCH V16 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385086118-11699-10-git-send-email-gaowanlong@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=bsd@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).