From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjq2v-0003FL-7v for qemu-devel@nongnu.org; Fri, 22 Nov 2013 07:41:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjq2p-0001UQ-8w for qemu-devel@nongnu.org; Fri, 22 Nov 2013 07:41:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjq2p-0001UH-0s for qemu-devel@nongnu.org; Fri, 22 Nov 2013 07:41:11 -0500 From: Paolo Bonzini Date: Fri, 22 Nov 2013 13:39:59 +0100 Message-Id: <1385124001-3576-18-git-send-email-pbonzini@redhat.com> In-Reply-To: <1385124001-3576-1-git-send-email-pbonzini@redhat.com> References: <1385124001-3576-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 17/19] scsi-disk: catch write protection errors in UNMAP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pl@kamp.de, ronniesahlberg@gmail.com, stefanha@redhat.com This is the same that is already done for WRITE SAME. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 74e6a14..4138268 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1543,6 +1543,7 @@ done: static void scsi_disk_emulate_unmap(SCSIDiskReq *r, uint8_t *inbuf) { + SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev); uint8_t *p = inbuf; int len = r->req.cmd.xfer; UnmapCBData *data; @@ -1560,6 +1561,11 @@ static void scsi_disk_emulate_unmap(SCSIDiskReq *r, uint8_t *inbuf) goto invalid_param_len; } + if (bdrv_is_read_only(s->qdev.conf.bs)) { + scsi_check_condition(r, SENSE_CODE(WRITE_PROTECTED)); + return; + } + data = g_new0(UnmapCBData, 1); data->r = r; data->inbuf = &p[8]; -- 1.8.4.2