qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/7] blkdebug/blkverify: Allow command-line configuration
Date: Fri, 22 Nov 2013 17:10:51 +0100	[thread overview]
Message-ID: <1385136658-16347-1-git-send-email-mreitz@redhat.com> (raw)

Currently, the configuration of blkdebug and blkverify is done through
the "filename" alone. There is now way of manually choosing blkdebug or
blkverify as a driver and using a normal image filename.

In the case of blkdebug, the filename starts with the protocol prefix,
follows up with the name of a configuration file and ends with the name
of the image file.

In the case of blkverify, the filename starts with the protocol prefix,
follows up with the raw reference image filename and ends with the name
of the image file.

This patch allows the configuration of both drivers completely through
command-line options. The driver has to be selected through the
file.driver option (or similar), the image filename has to be given as
the filename (obviously) and, depending on the driver, further options
have to be given to control the behavior.

In case of blkverify, the x-raw option specifies the name of the raw
reference image file.

In case of blkdebug, one may either set the config option to the
filename of a configuration file, or the contents of the configuration
file may be given directly on the command line (see description of patch
4 for an example).

v2:
 - Addressed Fam's comments:
    - Added patch 3
    - Fixed patch 4 and modified it to use the function introduced in
      patch 3
 - Removed unnecessary error_propagate() in patch 1 (affects patches 5
   and 6 as well)


Max Reitz (7):
  blkdebug: Use errp for read_config()
  blkdebug: Don't require sophisticated filename
  qdict: Add qdict_array_split()
  qemu-option: Add qemu_config_parse_qdict()
  blkdebug: Always call read_config()
  blkdebug: Use command-line in read_config()
  blkverify: Don't require protocol filename

 block/blkdebug.c           | 49 ++++++++++++++++--------
 block/blkverify.c          |  4 +-
 include/qapi/qmp/qdict.h   |  1 +
 include/qemu/config-file.h |  6 +++
 qobject/qdict.c            | 36 ++++++++++++++++++
 util/qemu-config.c         | 95 ++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 174 insertions(+), 17 deletions(-)

-- 
1.8.4.2

             reply	other threads:[~2013-11-22 16:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 16:10 Max Reitz [this message]
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config() Max Reitz
2013-11-25 13:40   ` Kevin Wolf
2013-11-25 19:42     ` Max Reitz
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 2/7] blkdebug: Don't require sophisticated filename Max Reitz
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 3/7] qdict: Add qdict_array_split() Max Reitz
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 4/7] qemu-option: Add qemu_config_parse_qdict() Max Reitz
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 5/7] blkdebug: Always call read_config() Max Reitz
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 6/7] blkdebug: Use command-line in read_config() Max Reitz
2013-11-22 16:10 ` [Qemu-devel] [PATCH v2 7/7] blkverify: Don't require protocol filename Max Reitz
2013-11-25 14:40   ` Kevin Wolf
2013-11-25 20:09     ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385136658-16347-1-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).