From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjtJf-0005V5-HE for qemu-devel@nongnu.org; Fri, 22 Nov 2013 11:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjtJZ-0006PL-Dr for qemu-devel@nongnu.org; Fri, 22 Nov 2013 11:10:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjtJZ-0006P9-3Q for qemu-devel@nongnu.org; Fri, 22 Nov 2013 11:10:41 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAMGAdJ3014772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Nov 2013 11:10:40 -0500 From: Max Reitz Date: Fri, 22 Nov 2013 17:10:52 +0100 Message-Id: <1385136658-16347-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1385136658-16347-1-git-send-email-mreitz@redhat.com> References: <1385136658-16347-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi , Max Reitz Use an Error variable in the read_config() function. Signed-off-by: Max Reitz --- block/blkdebug.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 16d2b91..9dfa712 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -271,7 +271,7 @@ static void remove_rule(BlkdebugRule *rule) g_free(rule); } -static int read_config(BDRVBlkdebugState *s, const char *filename) +static int read_config(BDRVBlkdebugState *s, const char *filename, Error **errp) { FILE *f; int ret; @@ -279,11 +279,16 @@ static int read_config(BDRVBlkdebugState *s, const char *filename) f = fopen(filename, "r"); if (f == NULL) { + error_setg_errno(errp, errno, "Could not read blkdebug config file " + "'%s'", filename); return -errno; } ret = qemu_config_parse(f, config_groups, filename); if (ret < 0) { + error_setg(errp, "Could not parse blkdebug config file '%s'", + filename); + ret = -EINVAL; goto fail; } @@ -370,9 +375,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict *options, int flags, /* Read rules from config file */ config = qemu_opt_get(opts, "config"); if (config) { - ret = read_config(s, config); - if (ret < 0) { - error_setg_errno(errp, -ret, "Could not read blkdebug config file"); + ret = read_config(s, config, errp); + if (ret) { goto fail; } } -- 1.8.4.2