* [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service
@ 2013-11-01 21:47 Tomoki Sekiyama
2013-11-03 9:59 ` Gal Hammer
2013-11-22 21:17 ` Michael Roth
0 siblings, 2 replies; 5+ messages in thread
From: Tomoki Sekiyama @ 2013-11-01 21:47 UTC (permalink / raw)
To: qemu-devel; +Cc: ghammer, mdroth, lcapitulino, pbonzini, seiji.aguchi, areis
Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when
no user is logging in to Windows, with an error message:
{"error":{"class":"GenericError",
"desc":"failed to add C:\\ to snapshotset: (error: 8004230f)"}}
To enable guest-fsfreeze-freeze/thaw without logging in users, this installs
a service to execute qemu-ga VSS provider COM+ application that has full
access privileges to the local system. The service will automatically be
removed when the COM+ application is deregistered.
This patch replaces ICOMAdminCatalog interface with ICOMAdminCatalog2
interface that contains CreateServiceForApplication() method in addition.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
---
qga/vss-win32/install.cpp | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index 37731a7..b791a6c 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -25,8 +25,8 @@ extern HINSTANCE g_hinstDll;
const GUID CLSID_COMAdminCatalog = { 0xF618C514, 0xDFB8, 0x11d1,
{0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
-const GUID IID_ICOMAdminCatalog = { 0xDD662187, 0xDFC2, 0x11d1,
- {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
+const GUID IID_ICOMAdminCatalog2 = { 0x790C6E0B, 0x9194, 0x4cc9,
+ {0x94, 0x26, 0xA4, 0x8A, 0x63, 0x18, 0x56, 0x96} };
const GUID CLSID_WbemLocator = { 0x4590f811, 0x1d3a, 0x11d0,
{0x89, 0x1f, 0x00, 0xaa, 0x00, 0x4b, 0x2e, 0x24} };
const GUID IID_IWbemLocator = { 0xdc12a687, 0x737f, 0x11cf,
@@ -141,7 +141,7 @@ static HRESULT QGAProviderFind(
HRESULT hr;
COMInitializer initializer;
COMPointer<IUnknown> pUnknown;
- COMPointer<ICOMAdminCatalog> pCatalog;
+ COMPointer<ICOMAdminCatalog2> pCatalog;
COMPointer<ICatalogCollection> pColl;
COMPointer<ICatalogObject> pObj;
_variant_t var;
@@ -149,7 +149,7 @@ static HRESULT QGAProviderFind(
chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
IID_IUnknown, (void **)pUnknown.replace()));
- chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
+ chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
(void **)pCatalog.replace()));
chk(pCatalog->GetCollection(_bstr_t(L"Applications"),
(IDispatch **)pColl.replace()));
@@ -206,7 +206,7 @@ STDAPI COMRegister(void)
HRESULT hr;
COMInitializer initializer;
COMPointer<IUnknown> pUnknown;
- COMPointer<ICOMAdminCatalog> pCatalog;
+ COMPointer<ICOMAdminCatalog2> pCatalog;
COMPointer<ICatalogCollection> pApps, pRoles, pUsersInRole;
COMPointer<ICatalogObject> pObj;
long n;
@@ -229,7 +229,7 @@ STDAPI COMRegister(void)
chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
IID_IUnknown, (void **)pUnknown.replace()));
- chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
+ chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
(void **)pCatalog.replace()));
/* Install COM+ Component */
@@ -273,6 +273,10 @@ STDAPI COMRegister(void)
goto out;
}
+ chk(pCatalog->CreateServiceForApplication(
+ _bstr_t(QGA_PROVIDER_LNAME), _bstr_t(QGA_PROVIDER_LNAME),
+ _bstr_t(L"SERVICE_AUTO_START"), _bstr_t(L"SERVICE_ERROR_NORMAL"),
+ _bstr_t(L""), _bstr_t(L".\\localsystem"), _bstr_t(L""), FALSE));
chk(pCatalog->InstallComponent(_bstr_t(QGA_PROVIDER_LNAME),
_bstr_t(dllPath), _bstr_t(tlbPath),
_bstr_t("")));
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service
2013-11-01 21:47 Tomoki Sekiyama
@ 2013-11-03 9:59 ` Gal Hammer
2013-11-22 21:17 ` Michael Roth
1 sibling, 0 replies; 5+ messages in thread
From: Gal Hammer @ 2013-11-03 9:59 UTC (permalink / raw)
To: Tomoki Sekiyama, qemu-devel
Cc: mdroth, lcapitulino, pbonzini, seiji.aguchi, areis
Reviewed-by: Gal Hammer <ghammer@redhat.com>
On 01/11/2013 23:47, Tomoki Sekiyama wrote:
> Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when
> no user is logging in to Windows, with an error message:
> {"error":{"class":"GenericError",
> "desc":"failed to add C:\\ to snapshotset: (error: 8004230f)"}}
>
> To enable guest-fsfreeze-freeze/thaw without logging in users, this installs
> a service to execute qemu-ga VSS provider COM+ application that has full
> access privileges to the local system. The service will automatically be
> removed when the COM+ application is deregistered.
>
> This patch replaces ICOMAdminCatalog interface with ICOMAdminCatalog2
> interface that contains CreateServiceForApplication() method in addition.
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> ---
> qga/vss-win32/install.cpp | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index 37731a7..b791a6c 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -25,8 +25,8 @@ extern HINSTANCE g_hinstDll;
>
> const GUID CLSID_COMAdminCatalog = { 0xF618C514, 0xDFB8, 0x11d1,
> {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
> -const GUID IID_ICOMAdminCatalog = { 0xDD662187, 0xDFC2, 0x11d1,
> - {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
> +const GUID IID_ICOMAdminCatalog2 = { 0x790C6E0B, 0x9194, 0x4cc9,
> + {0x94, 0x26, 0xA4, 0x8A, 0x63, 0x18, 0x56, 0x96} };
> const GUID CLSID_WbemLocator = { 0x4590f811, 0x1d3a, 0x11d0,
> {0x89, 0x1f, 0x00, 0xaa, 0x00, 0x4b, 0x2e, 0x24} };
> const GUID IID_IWbemLocator = { 0xdc12a687, 0x737f, 0x11cf,
> @@ -141,7 +141,7 @@ static HRESULT QGAProviderFind(
> HRESULT hr;
> COMInitializer initializer;
> COMPointer<IUnknown> pUnknown;
> - COMPointer<ICOMAdminCatalog> pCatalog;
> + COMPointer<ICOMAdminCatalog2> pCatalog;
> COMPointer<ICatalogCollection> pColl;
> COMPointer<ICatalogObject> pObj;
> _variant_t var;
> @@ -149,7 +149,7 @@ static HRESULT QGAProviderFind(
>
> chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
> IID_IUnknown, (void **)pUnknown.replace()));
> - chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
> + chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
> (void **)pCatalog.replace()));
> chk(pCatalog->GetCollection(_bstr_t(L"Applications"),
> (IDispatch **)pColl.replace()));
> @@ -206,7 +206,7 @@ STDAPI COMRegister(void)
> HRESULT hr;
> COMInitializer initializer;
> COMPointer<IUnknown> pUnknown;
> - COMPointer<ICOMAdminCatalog> pCatalog;
> + COMPointer<ICOMAdminCatalog2> pCatalog;
> COMPointer<ICatalogCollection> pApps, pRoles, pUsersInRole;
> COMPointer<ICatalogObject> pObj;
> long n;
> @@ -229,7 +229,7 @@ STDAPI COMRegister(void)
>
> chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
> IID_IUnknown, (void **)pUnknown.replace()));
> - chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
> + chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
> (void **)pCatalog.replace()));
>
> /* Install COM+ Component */
> @@ -273,6 +273,10 @@ STDAPI COMRegister(void)
> goto out;
> }
>
> + chk(pCatalog->CreateServiceForApplication(
> + _bstr_t(QGA_PROVIDER_LNAME), _bstr_t(QGA_PROVIDER_LNAME),
> + _bstr_t(L"SERVICE_AUTO_START"), _bstr_t(L"SERVICE_ERROR_NORMAL"),
> + _bstr_t(L""), _bstr_t(L".\\localsystem"), _bstr_t(L""), FALSE));
> chk(pCatalog->InstallComponent(_bstr_t(QGA_PROVIDER_LNAME),
> _bstr_t(dllPath), _bstr_t(tlbPath),
> _bstr_t("")));
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PULL 0/1 for-1.7] qemu-ga fsfreeze fix for Windows
@ 2013-11-22 21:08 Michael Roth
2013-11-22 21:08 ` [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service Michael Roth
0 siblings, 1 reply; 5+ messages in thread
From: Michael Roth @ 2013-11-22 21:08 UTC (permalink / raw)
To: qemu-devel; +Cc: tomoki.sekiyama, aliguori
Hi Anthony,
Please pull the following fix, which allows guest-freeze-fsfreeze to be
executed while a user is not logged in to the guest.
The following changes since commit 607bb022f2a44797cbf40e85e84da4134e2f0e01:
Update version for 1.7.0-rc1 release (2013-11-21 08:11:47 -0800)
are available in the git repository at:
git://github.com/mdroth/qemu.git qga-pull-2013-11-22
for you to fetch changes up to 3c040d5cba585e27eded8efc121ef599723581f8:
qemu-ga: vss-win32: Install VSS provider COM+ application service (2013-11-22 14:54:42 -0600)
----------------------------------------------------------------
Tomoki Sekiyama (1):
qemu-ga: vss-win32: Install VSS provider COM+ application service
qga/vss-win32/install.cpp | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service
2013-11-22 21:08 [Qemu-devel] [PULL 0/1 for-1.7] qemu-ga fsfreeze fix for Windows Michael Roth
@ 2013-11-22 21:08 ` Michael Roth
0 siblings, 0 replies; 5+ messages in thread
From: Michael Roth @ 2013-11-22 21:08 UTC (permalink / raw)
To: qemu-devel; +Cc: tomoki.sekiyama, aliguori
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when
no user is logging in to Windows, with an error message:
{"error":{"class":"GenericError",
"desc":"failed to add C:\\ to snapshotset: (error: 8004230f)"}}
To enable guest-fsfreeze-freeze/thaw without logging in users, this installs
a service to execute qemu-ga VSS provider COM+ application that has full
access privileges to the local system. The service will automatically be
removed when the COM+ application is deregistered.
This patch replaces ICOMAdminCatalog interface with ICOMAdminCatalog2
interface that contains CreateServiceForApplication() method in addition.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/vss-win32/install.cpp | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index 37731a7..b791a6c 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -25,8 +25,8 @@ extern HINSTANCE g_hinstDll;
const GUID CLSID_COMAdminCatalog = { 0xF618C514, 0xDFB8, 0x11d1,
{0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
-const GUID IID_ICOMAdminCatalog = { 0xDD662187, 0xDFC2, 0x11d1,
- {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
+const GUID IID_ICOMAdminCatalog2 = { 0x790C6E0B, 0x9194, 0x4cc9,
+ {0x94, 0x26, 0xA4, 0x8A, 0x63, 0x18, 0x56, 0x96} };
const GUID CLSID_WbemLocator = { 0x4590f811, 0x1d3a, 0x11d0,
{0x89, 0x1f, 0x00, 0xaa, 0x00, 0x4b, 0x2e, 0x24} };
const GUID IID_IWbemLocator = { 0xdc12a687, 0x737f, 0x11cf,
@@ -141,7 +141,7 @@ static HRESULT QGAProviderFind(
HRESULT hr;
COMInitializer initializer;
COMPointer<IUnknown> pUnknown;
- COMPointer<ICOMAdminCatalog> pCatalog;
+ COMPointer<ICOMAdminCatalog2> pCatalog;
COMPointer<ICatalogCollection> pColl;
COMPointer<ICatalogObject> pObj;
_variant_t var;
@@ -149,7 +149,7 @@ static HRESULT QGAProviderFind(
chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
IID_IUnknown, (void **)pUnknown.replace()));
- chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
+ chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
(void **)pCatalog.replace()));
chk(pCatalog->GetCollection(_bstr_t(L"Applications"),
(IDispatch **)pColl.replace()));
@@ -206,7 +206,7 @@ STDAPI COMRegister(void)
HRESULT hr;
COMInitializer initializer;
COMPointer<IUnknown> pUnknown;
- COMPointer<ICOMAdminCatalog> pCatalog;
+ COMPointer<ICOMAdminCatalog2> pCatalog;
COMPointer<ICatalogCollection> pApps, pRoles, pUsersInRole;
COMPointer<ICatalogObject> pObj;
long n;
@@ -229,7 +229,7 @@ STDAPI COMRegister(void)
chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
IID_IUnknown, (void **)pUnknown.replace()));
- chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
+ chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
(void **)pCatalog.replace()));
/* Install COM+ Component */
@@ -273,6 +273,10 @@ STDAPI COMRegister(void)
goto out;
}
+ chk(pCatalog->CreateServiceForApplication(
+ _bstr_t(QGA_PROVIDER_LNAME), _bstr_t(QGA_PROVIDER_LNAME),
+ _bstr_t(L"SERVICE_AUTO_START"), _bstr_t(L"SERVICE_ERROR_NORMAL"),
+ _bstr_t(L""), _bstr_t(L".\\localsystem"), _bstr_t(L""), FALSE));
chk(pCatalog->InstallComponent(_bstr_t(QGA_PROVIDER_LNAME),
_bstr_t(dllPath), _bstr_t(tlbPath),
_bstr_t("")));
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service
2013-11-01 21:47 Tomoki Sekiyama
2013-11-03 9:59 ` Gal Hammer
@ 2013-11-22 21:17 ` Michael Roth
1 sibling, 0 replies; 5+ messages in thread
From: Michael Roth @ 2013-11-22 21:17 UTC (permalink / raw)
To: Tomoki Sekiyama, qemu-devel
Cc: ghammer, lcapitulino, pbonzini, seiji.aguchi, areis
Quoting Tomoki Sekiyama (2013-11-01 16:47:25)
> Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when
> no user is logging in to Windows, with an error message:
> {"error":{"class":"GenericError",
> "desc":"failed to add C:\\ to snapshotset: (error: 8004230f)"}}
>
> To enable guest-fsfreeze-freeze/thaw without logging in users, this installs
> a service to execute qemu-ga VSS provider COM+ application that has full
> access privileges to the local system. The service will automatically be
> removed when the COM+ application is deregistered.
>
> This patch replaces ICOMAdminCatalog interface with ICOMAdminCatalog2
> interface that contains CreateServiceForApplication() method in addition.
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Thanks Tomoki, applied to qga branch and pull sent for 1.7:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/vss-win32/install.cpp | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index 37731a7..b791a6c 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -25,8 +25,8 @@ extern HINSTANCE g_hinstDll;
>
> const GUID CLSID_COMAdminCatalog = { 0xF618C514, 0xDFB8, 0x11d1,
> {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
> -const GUID IID_ICOMAdminCatalog = { 0xDD662187, 0xDFC2, 0x11d1,
> - {0xA2, 0xCF, 0x00, 0x80, 0x5F, 0xC7, 0x92, 0x35} };
> +const GUID IID_ICOMAdminCatalog2 = { 0x790C6E0B, 0x9194, 0x4cc9,
> + {0x94, 0x26, 0xA4, 0x8A, 0x63, 0x18, 0x56, 0x96} };
> const GUID CLSID_WbemLocator = { 0x4590f811, 0x1d3a, 0x11d0,
> {0x89, 0x1f, 0x00, 0xaa, 0x00, 0x4b, 0x2e, 0x24} };
> const GUID IID_IWbemLocator = { 0xdc12a687, 0x737f, 0x11cf,
> @@ -141,7 +141,7 @@ static HRESULT QGAProviderFind(
> HRESULT hr;
> COMInitializer initializer;
> COMPointer<IUnknown> pUnknown;
> - COMPointer<ICOMAdminCatalog> pCatalog;
> + COMPointer<ICOMAdminCatalog2> pCatalog;
> COMPointer<ICatalogCollection> pColl;
> COMPointer<ICatalogObject> pObj;
> _variant_t var;
> @@ -149,7 +149,7 @@ static HRESULT QGAProviderFind(
>
> chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
> IID_IUnknown, (void **)pUnknown.replace()));
> - chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
> + chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
> (void **)pCatalog.replace()));
> chk(pCatalog->GetCollection(_bstr_t(L"Applications"),
> (IDispatch **)pColl.replace()));
> @@ -206,7 +206,7 @@ STDAPI COMRegister(void)
> HRESULT hr;
> COMInitializer initializer;
> COMPointer<IUnknown> pUnknown;
> - COMPointer<ICOMAdminCatalog> pCatalog;
> + COMPointer<ICOMAdminCatalog2> pCatalog;
> COMPointer<ICatalogCollection> pApps, pRoles, pUsersInRole;
> COMPointer<ICatalogObject> pObj;
> long n;
> @@ -229,7 +229,7 @@ STDAPI COMRegister(void)
>
> chk(CoCreateInstance(CLSID_COMAdminCatalog, NULL, CLSCTX_INPROC_SERVER,
> IID_IUnknown, (void **)pUnknown.replace()));
> - chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog,
> + chk(pUnknown->QueryInterface(IID_ICOMAdminCatalog2,
> (void **)pCatalog.replace()));
>
> /* Install COM+ Component */
> @@ -273,6 +273,10 @@ STDAPI COMRegister(void)
> goto out;
> }
>
> + chk(pCatalog->CreateServiceForApplication(
> + _bstr_t(QGA_PROVIDER_LNAME), _bstr_t(QGA_PROVIDER_LNAME),
> + _bstr_t(L"SERVICE_AUTO_START"), _bstr_t(L"SERVICE_ERROR_NORMAL"),
> + _bstr_t(L""), _bstr_t(L".\\localsystem"), _bstr_t(L""), FALSE));
> chk(pCatalog->InstallComponent(_bstr_t(QGA_PROVIDER_LNAME),
> _bstr_t(dllPath), _bstr_t(tlbPath),
> _bstr_t("")));
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-22 21:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-22 21:08 [Qemu-devel] [PULL 0/1 for-1.7] qemu-ga fsfreeze fix for Windows Michael Roth
2013-11-22 21:08 ` [Qemu-devel] [PATCH] qemu-ga: vss-win32: Install VSS provider COM+ application service Michael Roth
-- strict thread matches above, loose matches on Subject: below --
2013-11-01 21:47 Tomoki Sekiyama
2013-11-03 9:59 ` Gal Hammer
2013-11-22 21:17 ` Michael Roth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).