* [Qemu-devel] [PATCH] configure: make --iasl option actually work
@ 2013-11-24 9:52 Michael S. Tsirkin
2013-11-24 12:54 ` Marcel Apfelbaum
2013-11-24 15:14 ` [Qemu-devel] [PATCH for 1.7] " Stefan Weil
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2013-11-24 9:52 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Richard Henderson, Stefan Hajnoczi,
Anthony Liguori, Paolo Bonzini
--iasl option was added to CC option parsing section by mistake,
it's not effective there and attempts to use cause
an 'unknown option' error.
Fix this up.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index f6d5ccd..0592ba7 100755
--- a/configure
+++ b/configure
@@ -272,8 +272,6 @@ for opt do
;;
--cxx=*) CXX="$optarg"
;;
- --iasl=*) iasl="$optarg"
- ;;
--source-path=*) source_path="$optarg"
;;
--cpu=*) cpu="$optarg"
@@ -649,6 +647,8 @@ for opt do
;;
--cxx=*)
;;
+ --iasl=*) iasl="$optarg"
+ ;;
--objcc=*) objcc="$optarg"
;;
--make=*) make="$optarg"
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: make --iasl option actually work
2013-11-24 9:52 [Qemu-devel] [PATCH] configure: make --iasl option actually work Michael S. Tsirkin
@ 2013-11-24 12:54 ` Marcel Apfelbaum
2013-11-24 15:14 ` [Qemu-devel] [PATCH for 1.7] " Stefan Weil
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Apfelbaum @ 2013-11-24 12:54 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Peter Maydell, Stefan Hajnoczi, qemu-devel, Anthony Liguori,
Paolo Bonzini, Richard Henderson
On Sun, 2013-11-24 at 11:52 +0200, Michael S. Tsirkin wrote:
> --iasl option was added to CC option parsing section by mistake,
> it's not effective there and attempts to use cause
> an 'unknown option' error.
>
> Fix this up.
Now it works...
Tested-by: Marcel Apfelbaum <marcel.a@redhat.com>
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f6d5ccd..0592ba7 100755
> --- a/configure
> +++ b/configure
> @@ -272,8 +272,6 @@ for opt do
> ;;
> --cxx=*) CXX="$optarg"
> ;;
> - --iasl=*) iasl="$optarg"
> - ;;
> --source-path=*) source_path="$optarg"
> ;;
> --cpu=*) cpu="$optarg"
> @@ -649,6 +647,8 @@ for opt do
> ;;
> --cxx=*)
> ;;
> + --iasl=*) iasl="$optarg"
> + ;;
> --objcc=*) objcc="$optarg"
> ;;
> --make=*) make="$optarg"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for 1.7] configure: make --iasl option actually work
2013-11-24 9:52 [Qemu-devel] [PATCH] configure: make --iasl option actually work Michael S. Tsirkin
2013-11-24 12:54 ` Marcel Apfelbaum
@ 2013-11-24 15:14 ` Stefan Weil
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2013-11-24 15:14 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Peter Maydell, Paolo Bonzini, Anthony Liguori, Stefan Hajnoczi,
Richard Henderson
Am 24.11.2013 10:52, schrieb Michael S. Tsirkin:
> --iasl option was added to CC option parsing section by mistake,
> it's not effective there and attempts to use cause
> an 'unknown option' error.
>
> Fix this up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f6d5ccd..0592ba7 100755
> --- a/configure
> +++ b/configure
> @@ -272,8 +272,6 @@ for opt do
> ;;
> --cxx=*) CXX="$optarg"
> ;;
> - --iasl=*) iasl="$optarg"
> - ;;
> --source-path=*) source_path="$optarg"
> ;;
> --cpu=*) cpu="$optarg"
> @@ -649,6 +647,8 @@ for opt do
> ;;
> --cxx=*)
> ;;
> + --iasl=*) iasl="$optarg"
> + ;;
> --objcc=*) objcc="$optarg"
> ;;
> --make=*) make="$optarg"
Reviewed-by: Stefan Weil <sw@weilnetz.de>
This is a trivial bug fix, so maybe it should be committed for QEMU 1.7.
Therefore I changed the subject of the e-mail to include 'for 1.7'.
Regards,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-24 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-24 9:52 [Qemu-devel] [PATCH] configure: make --iasl option actually work Michael S. Tsirkin
2013-11-24 12:54 ` Marcel Apfelbaum
2013-11-24 15:14 ` [Qemu-devel] [PATCH for 1.7] " Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).