From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1VkZOu-0001LB-Bd
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 08:07:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1VkZOl-0003qK-VT
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 08:07:00 -0500
Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:53698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1VkZOl-0003pK-OP
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 08:06:51 -0500
Received: by mail-wg0-f47.google.com with SMTP id n12so1768127wgh.14
	for <qemu-devel@nongnu.org>; Sun, 24 Nov 2013 05:06:50 -0800 (PST)
Message-ID: <1385298244.2177.25.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Date: Sun, 24 Nov 2013 15:04:04 +0200
In-Reply-To: <20131124095239.GA30786@redhat.com>
References: <20131124095239.GA30786@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: make it possible to disable IASL
Reply-To: marcel.a@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On Sun, 2013-11-24 at 11:52 +0200, Michael S. Tsirkin wrote:
> Useful for platforms with a broken IASL.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 0592ba7..d0a0abe 100755
> --- a/configure
> +++ b/configure
> @@ -1080,6 +1080,7 @@ echo "  --source-path=PATH       path of source code [$source_path]"
>  echo "  --cross-prefix=PREFIX    use PREFIX for compile tools [$cross_prefix]"
>  echo "  --cc=CC                  use C compiler CC [$cc]"
>  echo "  --iasl=IASL              use ACPI compiler IASL [$iasl]"
> +echo "                           iasl='' (empty string) disables ACPI compiler"
>  echo "  --host-cc=CC             use C compiler CC [$host_cc] for code run at"
>  echo "                           build time"
>  echo "  --cxx=CXX                use C++ compiler CXX [$cxx]"
> @@ -4269,7 +4270,7 @@ else
>  fi
>  echo "PYTHON=$python" >> $config_host_mak
>  echo "CC=$cc" >> $config_host_mak
> -if $iasl -h > /dev/null 2>&1; then
> +if test "$iasl" && $iasl -h > /dev/null 2>&1; then
>    echo "IASL=$iasl" >> $config_host_mak
>  fi
>  echo "CC_I386=$cc_i386" >> $config_host_mak

I tried to disable iasl without this patch and it worked for me...
I used:
    - [Qemu-devel] [PATCH] configure: make --iasl option actually work
    - ./configure --iasl="" (or --iasl=)
and it worked (no sign of IASL in config-host.mak)

I think this is because the prev test "$iasl -h > /dev/null 2>&1"
fails of course.

I don't get it how <test "$iasl"> helps if iasl is broken.
Thanks,
Marcel