qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH] vl: remove (max_cpus > 255) check from smp_parse
Date: Mon, 25 Nov 2013 14:39:10 +1100	[thread overview]
Message-ID: <1385350750-21468-1-git-send-email-aik@ozlabs.ru> (raw)

Since modern POWER7/POWER8 chips can have more that 256 CPU threads
(>2000 actually), remove this check from smp_parse.

The CPUs number is still checked against machine->max_cpus and this check
should be enough not to break other archs.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 vl.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/vl.c b/vl.c
index 8d5d874..e6ed260 100644
--- a/vl.c
+++ b/vl.c
@@ -1420,10 +1420,6 @@ static void smp_parse(QemuOpts *opts)
         max_cpus = smp_cpus;
     }
 
-    if (max_cpus > 255) {
-        fprintf(stderr, "Unsupported number of maxcpus\n");
-        exit(1);
-    }
     if (max_cpus < smp_cpus) {
         fprintf(stderr, "maxcpus must be equal to or greater than smp\n");
         exit(1);
-- 
1.8.4.rc4

             reply	other threads:[~2013-11-25  3:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  3:39 Alexey Kardashevskiy [this message]
2013-12-02 17:06 ` [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse Michael Tokarev
2013-12-02 22:09   ` Andreas Färber
2013-12-02 23:03     ` Alexey Kardashevskiy
2013-12-03  9:00       ` Markus Armbruster
2013-12-03 13:30       ` Andreas Färber
2013-12-03 14:47         ` Eduardo Habkost
2013-12-04  5:50           ` Alexey Kardashevskiy
2013-12-04 12:48             ` Eduardo Habkost
2014-02-14  6:56               ` Alexey Kardashevskiy
2014-02-14  7:34                 ` Paolo Bonzini
2013-12-03 10:44     ` Igor Mammedov
2013-12-03 14:33       ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385350750-21468-1-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).