From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42872)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VkqGE-0006ep-NI
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 02:07:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VkqG8-0008Kg-OS
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 02:07:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53772)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VkqG8-0008KT-FK
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 02:07:04 -0500
Message-ID: <1385362813.25009.6.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 25 Nov 2013 08:00:13 +0100
In-Reply-To: <5291D335.7040206@weilnetz.de>
References: <CAJSP0QU9p_+wS9_uBSd80ismeNcBO0hUyGQn8Enc34qyg4r_sw@mail.gmail.com>
	<CEB25C37.8743%Tomoki.Sekiyama@hds.com>
	<20131121084046.GE27039@stefanha-thinkpad.redhat.com>
	<528F000C.4040103@weilnetz.de>
	<20131122105412.GD24388@stefanha-thinkpad.redhat.com>
	<1385124694.3681.87.camel@nilsson.home.kraxel.org>
	<5291D335.7040206@weilnetz.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Buildbot failure: MinGW
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On So, 2013-11-24 at 11:21 +0100, Stefan Weil wrote:
> Am 22.11.2013 13:51, schrieb Gerd Hoffmann:
> >   Hi,
> >
> >>> 'make check' for MinGW cross builds needs an installation of wine to run
> >>> the resulting exe files.
> > I don't think it is a good idea to run tests for cross builds by
> > default.
> >
> > cheers,
> >   Gerd
> 
> Why not?

Because making them run requires extra setup effort on the host which
you can't assume is there.

> In this case (MinGW), setting up cross builds is rather easy,
> and also testing them with Wine seems to be easy and successful: it
> detects the current coroutine problem, for example.

It makes sense to be able to run those checks on wine, no question.  But
simply assuming wine is there and run them unconditionally isn't a good
idea IMHO.

I think we should either have "make check" autodetect whenever wine is
present, or have a separate make target for tests which require wine
which is not run by default.

cheers,
  Gerd