From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkrYE-0004AX-Gg for qemu-devel@nongnu.org; Mon, 25 Nov 2013 03:29:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkrY7-0005Az-W8 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 03:29:50 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:44750 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkrY7-0005A9-Jf for qemu-devel@nongnu.org; Mon, 25 Nov 2013 03:29:43 -0500 From: Peter Lieven Date: Mon, 25 Nov 2013 09:29:17 +0100 Message-Id: <1385368158-4364-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [RFC][PATCH 1.8] block/iscsi: set bdi->cluster_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , ronniesahlberg@gmail.com, stefanha@redhat.com this patch aims to set bdi->cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Signed-off-by: Peter Lieven --- block/iscsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index b7b5238..3a4c5d4 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1569,6 +1569,12 @@ static int iscsi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) IscsiLun *iscsilun = bs->opaque; bdi->unallocated_blocks_are_zero = !!iscsilun->lbprz; bdi->can_write_zeroes_with_unmap = iscsilun->lbprz && iscsilun->lbp.lbpws; + bdi->cluster_size = iscsilun->bl.opt_xfer_len * iscsilun->block_size; + /* if opt_xfer_len is not specified guess the internal page size of the + * iscsi target by the means of opt_unmap_gran */ + if (bdi->cluster_size == 0) { + bdi->cluster_size = iscsilun->bl.opt_unmap_gran * iscsilun->block_size; + } return 0; } -- 1.7.9.5