From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl23i-0001Ov-Ph for qemu-devel@nongnu.org; Mon, 25 Nov 2013 14:43:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl23c-0006MF-Dz for qemu-devel@nongnu.org; Mon, 25 Nov 2013 14:43:02 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:53397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl23c-0006MB-88 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 14:42:56 -0500 From: Matthew Garrett Date: Mon, 25 Nov 2013 14:42:43 -0500 Message-Id: <1385408563-14331-1-git-send-email-matthew.garrett@nebula.com> Subject: [Qemu-devel] [PATCH] migration: Fix rate limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Matthew Garrett The migration thread appears to want to allow writeout to occur at full speed rather than being rate limited during completion of state saving, but sets the limit to INT_MAX when xfer_limit is INT64_MAX. This causes problems if there's more than 2GB of state left to save at this point. It probably ought to just be INT64_MAX instead. Signed-off-by: Matthew Garrett --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 2b1ab20..ff00bfb 100644 --- a/migration.c +++ b/migration.c @@ -583,7 +583,7 @@ static void *migration_thread(void *opaque) ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE); if (ret >= 0) { - qemu_file_set_rate_limit(s->file, INT_MAX); + qemu_file_set_rate_limit(s->file, INT64_MAX); qemu_savevm_state_complete(s->file); } qemu_mutex_unlock_iothread(); -- 1.8.4.2