From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl9uh-0007k3-Gb for qemu-devel@nongnu.org; Mon, 25 Nov 2013 23:06:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl9ub-00012s-4N for qemu-devel@nongnu.org; Mon, 25 Nov 2013 23:06:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl9ua-00012g-TN for qemu-devel@nongnu.org; Mon, 25 Nov 2013 23:06:09 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQ467C1007277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Nov 2013 23:06:07 -0500 From: Fam Zheng Date: Tue, 26 Nov 2013 12:05:28 +0800 Message-Id: <1385438728-17924-8-git-send-email-famz@redhat.com> In-Reply-To: <1385438728-17924-1-git-send-email-famz@redhat.com> References: <1385438728-17924-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v5 7/7] block: Allow backup on referenced named BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, hbrock@redhat.com, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng --- block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block.c b/block.c index d633f2b..bb279d2 100644 --- a/block.c +++ b/block.c @@ -987,6 +987,8 @@ int bdrv_open_backing_file(BlockDriverState *bs, const char *backing_bs, "device is used as backing hd of '%s'", bs->device_name); bdrv_op_block_all(bs->backing_hd, bs->backing_blocker); + bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_BACKUP_SOURCE, + bs->backing_blocker); pstrcpy(bs->backing_file, sizeof(bs->backing_file), bs->backing_hd->filename); pstrcpy(bs->backing_format, sizeof(bs->backing_format), -- 1.8.4.2