From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCIc-00048C-Bm for qemu-devel@nongnu.org; Tue, 26 Nov 2013 01:39:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlCIU-0000kp-ED for qemu-devel@nongnu.org; Tue, 26 Nov 2013 01:39:06 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:38132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCIT-0000kA-Li for qemu-devel@nongnu.org; Tue, 26 Nov 2013 01:38:58 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Nov 2013 16:38:51 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 69A6A2CE8052 for ; Tue, 26 Nov 2013 17:38:49 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rAQ6cSYU5701940 for ; Tue, 26 Nov 2013 17:38:36 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rAQ6cdFt017568 for ; Tue, 26 Nov 2013 17:38:39 +1100 From: Xu Wang Date: Tue, 26 Nov 2013 01:38:29 -0500 Message-Id: <1385447913-19004-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V9 0/4] Refine and export backing file loop check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to block.c and build a independent function named bdrv_ backing_file_loop_check(). Backing file loop checking is added before image created, before change backing file and before system boot. Updates from V8: 1. Delete duplicate info (such as @filename) in the error_setg(). 2. Change parameter from @fmt into @drv. Updates from V7: 1. Replace all error_report() in bdrv_backing_chain_okay() with error_setg(). 2. Fix error output in bdrv_img_create() when backing file doesn't exist. 3. Add output in the bdrv_change_backing_file() (if not errp would has no way out). Updates from V6: 1. Combine bdrv_backing_chain_okay() and bdrv_new_chain_okay() into one. 2. Delete bdrv_find_format() in the backing_chain_has_loop(). 3. Comments syntax and function naming updates. Updates from V5: 1. Simplify the function of loop checking (Just filename comparation. Thanks Eric's suggestion). 2. Delete WIN32 platform support (There is no need to this patch now). 3. Adjust position of backing file loop checking (calling checking function before change happen). 4. Function name updates and comments description fix. Updates from V4: 1. Add backing file loop check in bdrv_new_open(). 2. Adjust open file logic of collect_image_info_list() (bdrv_new_open() is called only once when opening the whole chain). 3. Remove redundant brackets in lnk file check logic. 4. Add error output in bdrv_img_create(). 5. Remove MAX_PATH_LEN to use PATH_MAX instead. Updates from V3: 1. Comments fix for function bdrv_backing_file_loop_check(). 2. Add ret check for fseek()/fread() in get_lnk_target_file(). 3. Add limit of shortcuts filename length reading during comparing. 4. Add error_report() in driv_init(). 5. Remove redundant loop check in qcow2/qed_change_backing_file(). Updates from V2: 1. Removed parameter @chain from bdrv_backing_file_loop_check() 2. Comments and format fix, all patches were checked by checkpatch.pl 3. Fixed *bs leak. 4. Improved logic of .lnk file recognization. 5. Add filename lenth limit check in while() 6. Changed get_win_inode() to get_inode() and move all inode get method into it to make logic more simpler. 7. Added value of @fmt as suggested. 8. Added backing file loop check in qcow2.c/qed.c Xu Wang (4): block/qemu-img: Refine and export infinite loop checking in collect_image_info_list() block: Add check infinite loop in bdrv_img_create() block: Add backing file loop check in change_backing_file() blockdev: Add infinite loop check in drive_init() block.c | 100 ++++++++++++++++++++++++++++++++++++++++++++++---- blockdev.c | 7 ++++ include/block/block.h | 3 ++ qemu-img.c | 52 +++++++++++++------------- 4 files changed, 128 insertions(+), 34 deletions(-) -- 1.8.1.4