From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCIm-0004FR-AL for qemu-devel@nongnu.org; Tue, 26 Nov 2013 01:39:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlCId-0000me-8s for qemu-devel@nongnu.org; Tue, 26 Nov 2013 01:39:16 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:47932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCIc-0000mK-Il for qemu-devel@nongnu.org; Tue, 26 Nov 2013 01:39:07 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Nov 2013 16:39:04 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 927C32BB0056 for ; Tue, 26 Nov 2013 17:39:01 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rAQ6L7Eh40108260 for ; Tue, 26 Nov 2013 17:21:07 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rAQ6d06v018049 for ; Tue, 26 Nov 2013 17:39:00 +1100 From: Xu Wang Date: Tue, 26 Nov 2013 01:38:33 -0500 Message-Id: <1385447913-19004-5-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1385447913-19004-1-git-send-email-gesaint@linux.vnet.ibm.com> References: <1385447913-19004-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V9 4/4] blockdev: Add infinite loop check in drive_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang Check the backing file for a loop during image boot, to avoid a lack or response or segfault. Signed-off-by: Xu Wang --- blockdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/blockdev.c b/blockdev.c index 330aa4a..e39fc27 100644 --- a/blockdev.c +++ b/blockdev.c @@ -511,6 +511,13 @@ static DriveInfo *blockdev_init(QDict *bs_opts, bdrv_flags |= ro ? 0 : BDRV_O_RDWR; + /* Add backing file loop check */ + if (!bdrv_backing_chain_okay(file, drv, NULL, &error)) { + error_setg(errp, "drive_init: backing file loop check failed. %s", + error_get_pretty(error)); + goto err; + } + QINCREF(bs_opts); ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv, &error); -- 1.8.1.4