From: Hannes Reinecke <hare@suse.de>
To: Andreas Faerber <afaerber@suse.de>
Cc: Hannes Reinecke <hare@suse.de>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH] qdev: Validate hex properties
Date: Tue, 26 Nov 2013 16:05:38 +0100 [thread overview]
Message-ID: <1385478338-27433-1-git-send-email-hare@suse.de> (raw)
strtoull() might return '-1' to signify an overflow.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
hw/core/qdev-properties.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index dc8ae69..5761295 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -202,6 +202,9 @@ static int parse_hex8(DeviceState *dev, Property *prop, const char *str)
if ((*end != '\0') || (end == str)) {
return -EINVAL;
}
+ if (*ptr == (uint8_t)-1) {
+ return -ERANGE;
+ }
return 0;
}
@@ -333,6 +336,9 @@ static int parse_hex32(DeviceState *dev, Property *prop, const char *str)
if ((*end != '\0') || (end == str)) {
return -EINVAL;
}
+ if (*ptr == (uint32_t)-1) {
+ return -ERANGE;
+ }
return 0;
}
@@ -400,6 +406,9 @@ static int parse_hex64(DeviceState *dev, Property *prop, const char *str)
if ((*end != '\0') || (end == str)) {
return -EINVAL;
}
+ if (*ptr == (uint64_t)-1) {
+ return -ERANGE;
+ }
return 0;
}
--
1.8.1.4
next reply other threads:[~2013-11-26 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 15:05 Hannes Reinecke [this message]
2013-11-26 15:15 ` [Qemu-devel] [PATCH] qdev: Validate hex properties Peter Maydell
2013-11-26 15:15 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385478338-27433-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).