From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven <pl@kamp.de>,
stefanha@redhat.com
Subject: [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb)
Date: Wed, 27 Nov 2013 11:07:08 +0100 [thread overview]
Message-ID: <1385546829-3839-9-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1385546829-3839-1-git-send-email-pl@kamp.de>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
qemu-img.c | 4 ++--
qemu-img.texi | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 9bb1f6f..8b5f3da 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -100,7 +100,7 @@ static void help(void)
" '-h' with or without a command shows this help and lists the supported formats\n"
" '-p' show progress of command (only certain commands)\n"
" '-q' use Quiet mode - do not print any output (except errors)\n"
- " '-S' indicates the consecutive number of bytes (defaults to 4k) that must\n"
+ " '-S' indicates the consecutive number of bytes (defaults to 64k) that must\n"
" contain only zeros for qemu-img to create a sparse image during\n"
" conversion. If the number of bytes is 0, the source will not be scanned for\n"
" unallocated or zero sectors, and the destination image will always be\n"
@@ -1141,7 +1141,7 @@ static int img_convert(int argc, char **argv)
QEMUOptionParameter *out_baseimg_param;
char *options = NULL;
const char *snapshot_name = NULL;
- int min_sparse = 8; /* Need at least 4k of zeros for sparse detection */
+ int min_sparse = 128; /* Need at least 64k of zeros for sparse detection */
bool quiet = false;
Error *local_err = NULL;
diff --git a/qemu-img.texi b/qemu-img.texi
index da36975..4add6ce 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -193,7 +193,7 @@ Image conversion is also useful to get smaller image when using a
growable format such as @code{qcow} or @code{cow}: the empty sectors
are detected and suppressed from the destination image.
-@var{sparse_size} indicates the consecutive number of bytes (defaults to 4k)
+@var{sparse_size} indicates the consecutive number of bytes (defaults to 64k)
that must contain only zeros for qemu-img to create a sparse image during
conversion. If @var{sparse_size} is 0, the source will not be scanned for
unallocated or zero sectors, and the destination image will always be
--
1.7.9.5
next prev parent reply other threads:[~2013-11-27 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 10:07 [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert Peter Lieven
2013-11-27 10:17 ` Paolo Bonzini
2013-12-04 16:46 ` Stefan Hajnoczi
2013-12-04 16:51 ` Peter Lieven
2013-12-05 10:30 ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 3/9] block/iscsi: set bdi->cluster_size Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 4/9] block: add opt_transfer_length to BlockLimits Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length Peter Lieven
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert Peter Lieven
2013-12-05 13:30 ` Eric Blake
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request length to an aligned sector Peter Lieven
2013-12-04 15:49 ` Stefan Hajnoczi
2013-12-04 15:56 ` Peter Lieven
2013-12-05 10:33 ` Stefan Hajnoczi
2013-11-27 10:07 ` Peter Lieven [this message]
2013-12-04 16:43 ` [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb) Stefan Hajnoczi
2013-12-04 16:46 ` Peter Lieven
2013-12-05 2:12 ` Eric Blake
2013-12-05 4:55 ` Peter Lieven
2013-12-05 10:35 ` Stefan Hajnoczi
2013-11-27 10:07 ` [Qemu-devel] [PATCHv3 1.8 9/9] qemu-img: decrease progress update interval on convert Peter Lieven
2013-12-05 12:15 ` [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations Stefan Hajnoczi
2013-12-05 14:55 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385546829-3839-9-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).