From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, Jiri Denemark <jdenemar@redhat.com>
Subject: [Qemu-devel] [PATCH 5/7] target-i386: Call x86_cpu_load_def() earlier
Date: Wed, 27 Nov 2013 17:34:07 -0200 [thread overview]
Message-ID: <1385580849-10777-6-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1385580849-10777-1-git-send-email-ehabkost@redhat.com>
As we will initialize the X86CPU fields on instance_init eventually,
move the code that initializes the X86CPU data based on the CPU model
name closer to the object_new() call.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index f55caea..7f94a08 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1874,6 +1874,11 @@ X86CPU *cpu_x86_create(const char *cpu_model, DeviceState *icc_bridge,
features = model_pieces[1];
cpu = X86_CPU(object_new(TYPE_X86_CPU));
+ x86_cpu_load_def(cpu, name, &error);
+ if (error) {
+ goto out;
+ }
+
#ifndef CONFIG_USER_ONLY
if (icc_bridge == NULL) {
error_setg(&error, "Invalid icc-bridge value");
@@ -1883,11 +1888,6 @@ X86CPU *cpu_x86_create(const char *cpu_model, DeviceState *icc_bridge,
object_unref(OBJECT(cpu));
#endif
- x86_cpu_load_def(cpu, name, &error);
- if (error) {
- goto out;
- }
-
/* Emulate per-model subclasses for global properties */
typename = g_strdup_printf("%s-" TYPE_X86_CPU, name);
qdev_prop_set_globals_for_type(DEVICE(cpu), typename, &error);
--
1.8.3.1
next prev parent reply other threads:[~2013-11-27 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 19:34 [Qemu-devel] [PATCH 0/7] x86 CPU subclasses, take 6 Eduardo Habkost
2013-11-27 19:34 ` [Qemu-devel] [PATCH 1/7] target-i386: Eliminate CONFIG_KVM #ifdefs Eduardo Habkost
2013-12-09 18:17 ` Paolo Bonzini
2013-12-10 18:55 ` [Qemu-devel] [PATCH 1/7 v2] " Eduardo Habkost
2013-12-11 1:36 ` Richard Henderson
2013-12-11 16:11 ` Eduardo Habkost
2013-12-11 16:31 ` [Qemu-devel] [PATCH 1/7 v3] " Eduardo Habkost
2013-11-27 19:34 ` [Qemu-devel] [PATCH 2/7] target-i386: Don't change x86_def_t struct on cpu_x86_register() Eduardo Habkost
2013-11-27 19:34 ` [Qemu-devel] [PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init Eduardo Habkost
2013-11-27 19:34 ` [Qemu-devel] [PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def() Eduardo Habkost
2013-11-27 19:34 ` Eduardo Habkost [this message]
2013-11-27 19:34 ` [Qemu-devel] [PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition Eduardo Habkost
2013-11-27 19:34 ` [Qemu-devel] [RFC 7/7] target-i386: CPU model subclasses Eduardo Habkost
2013-12-09 18:07 ` [Qemu-devel] [PATCH 0/7] x86 CPU subclasses, take 6 Eduardo Habkost
2013-12-09 18:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385580849-10777-6-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).