From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chen.fan.fnst@cn.fujitsu.com>) id 1VlqD4-0004Af-Bb
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 20:16:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chen.fan.fnst@cn.fujitsu.com>) id 1VlqCz-0002EW-Jx
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 20:16:02 -0500
Received: from [222.73.24.84] (port=33014 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chen.fan.fnst@cn.fujitsu.com>) id 1VlqCy-0002Cf-U5
	for qemu-devel@nongnu.org; Wed, 27 Nov 2013 20:15:57 -0500
Message-ID: <1385601243.23188.7.camel@G08FNSTD131468>
From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Date: Thu, 28 Nov 2013 09:14:03 +0800
In-Reply-To: <5295FAE3.5060900@redhat.com>
References: <cover.1381304904.git.chen.fan.fnst@cn.fujitsu.com>
	<c0ed5d547e9b322c1319049707f695b6c3922ce9.1381304904.git.chen.fan.fnst@cn.fujitsu.com>
	<5295FAE3.5060900@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [Qemu-devel] [RFC qom-cpu v4 05/10] qmp: add 'cpu-del' command
 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Wed, 2013-11-27 at 07:00 -0700, Eric Blake wrote:
> On 10/09/2013 03:43 AM, Chen Fan wrote:
> > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> > ---
> >  hw/i386/pc.c         |  6 ++++++
> >  hw/i386/pc_piix.c    |  3 ++-
> >  include/hw/boards.h  |  2 ++
> >  include/hw/i386/pc.h |  1 +
> >  qapi-schema.json     | 12 ++++++++++++
> >  qmp-commands.hx      | 23 +++++++++++++++++++++++
> >  qmp.c                |  9 +++++++++
> >  7 files changed, 55 insertions(+), 1 deletion(-)
> 
> > +++ b/qapi-schema.json
> > @@ -1479,6 +1479,18 @@
> >  ##
> >  { 'command': 'cpu-add', 'data': {'id': 'int'} }
> >  
> > +# @cpu-del
> > +
> > +# Deletes CPU with specified ID
> > +#
> > +# @id: ID of CPU to be deleted, valid values [0..max_cpus)
> > +#
> > +# Returns: Nothing on success
> > +#
> > +# Since 1.7
> 
> Since this mail is still titled RFC, there's no way it will make it into
> 1.7.  Are you shooting for 1.8?
> 
Hi, this patchseries had not been commented yet, maybe I should send it
again after Rebase without RFC for 1.8. 

Thanks,
Chen