From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm4Qz-0004BI-Hm for qemu-devel@nongnu.org; Thu, 28 Nov 2013 11:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm4Qp-0002w7-Gx for qemu-devel@nongnu.org; Thu, 28 Nov 2013 11:27:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm4Qp-0002v2-8f for qemu-devel@nongnu.org; Thu, 28 Nov 2013 11:27:11 -0500 From: armbru@redhat.com Date: Thu, 28 Nov 2013 17:26:56 +0100 Message-Id: <1385656023-11519-4-git-send-email-armbru@redhat.com> In-Reply-To: <1385656023-11519-1-git-send-email-armbru@redhat.com> References: <1385656023-11519-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v4 03/10] cpu: Document why cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, marcel.a@redhat.com, afaerber@suse.de, aliguori@amazon.com, peter.maydell@linaro.org From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell --- qom/cpu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index 09c15e6..6e0d54e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass, void *data) k->gdb_read_register = cpu_common_gdb_read_register; k->gdb_write_register = cpu_common_gdb_write_register; dc->realize = cpu_common_realizefn; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ + /* + * Reason: CPUs still need special care by board code: wiring up + * IRQs, adding reset handlers, halting non-first CPUS, ... + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo cpu_type_info = { -- 1.8.1.4