From: Michael Walle <michael@walle.cc>
To: qemu-devel@nongnu.org
Cc: Michael Walle <michael@walle.cc>,
Antony Pavlov <antonynpavlov@gmail.com>
Subject: [Qemu-devel] [PULL v3 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()
Date: Thu, 28 Nov 2013 19:43:13 +0100 [thread overview]
Message-ID: <1385664202-13339-4-git-send-email-michael@walle.cc> (raw)
In-Reply-To: <1385664202-13339-1-git-send-email-michael@walle.cc>
From: Antony Pavlov <antonynpavlov@gmail.com>
qemu_chr_fe_write() is capable of returning 0
to indicate EAGAIN (and friends) and we don't
handle this.
Just change it to qemu_chr_fe_write_all() to fix.
Reported-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Acked-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Michael Walle <michael@walle.cc>
---
hw/char/milkymist-uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c
index 2c52a0f..da51f82 100644
--- a/hw/char/milkymist-uart.c
+++ b/hw/char/milkymist-uart.c
@@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t value,
switch (addr) {
case R_RXTX:
if (s->chr) {
- qemu_chr_fe_write(s->chr, &ch, 1);
+ qemu_chr_fe_write_all(s->chr, &ch, 1);
}
s->regs[R_STAT] |= STAT_TX_EVT;
break;
--
1.7.10.4
next prev parent reply other threads:[~2013-11-28 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 18:43 [Qemu-devel] [PULL v3 00/12] target-lm32 updates Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 01/12] lm32_sys: increase test case name length limit Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 02/12] tests: lm32: new rule for single test cases Michael Walle
2013-11-28 18:43 ` Michael Walle [this message]
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all() Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 05/12] milkymist-vgafb: swap pixel data in source buffer Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 06/12] target-lm32: kill cpu_abort() calls Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 07/12] target-lm32: move model features to LM32CPU Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 08/12] target-lm32: add breakpoint/watchpoint support Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 09/12] lm32_sys: print test result on stderr Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 10/12] lm32_sys: dump cpu state if test case fails Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 11/12] target-lm32: stop VM on illegal or unknown instruction Michael Walle
2013-11-28 18:43 ` [Qemu-devel] [PULL v3 12/12] hw/lm32: print error if cpu model is not found Michael Walle
2013-12-12 22:20 ` [Qemu-devel] [PULL v3 00/12] target-lm32 updates Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385664202-13339-4-git-send-email-michael@walle.cc \
--to=michael@walle.cc \
--cc=antonynpavlov@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).