From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm6ZQ-0004QT-RF for qemu-devel@nongnu.org; Thu, 28 Nov 2013 13:44:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm6ZG-0004Vo-Fj for qemu-devel@nongnu.org; Thu, 28 Nov 2013 13:44:12 -0500 Received: from ssl.serverraum.org ([88.198.40.39]:53822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm6ZG-0004Vb-9d for qemu-devel@nongnu.org; Thu, 28 Nov 2013 13:44:02 -0500 From: Michael Walle Date: Thu, 28 Nov 2013 19:43:13 +0100 Message-Id: <1385664202-13339-4-git-send-email-michael@walle.cc> In-Reply-To: <1385664202-13339-1-git-send-email-michael@walle.cc> References: <1385664202-13339-1-git-send-email-michael@walle.cc> Subject: [Qemu-devel] [PULL v3 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Walle , Antony Pavlov From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael Walle --- hw/char/milkymist-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index 2c52a0f..da51f82 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t value, switch (addr) { case R_RXTX: if (s->chr) { - qemu_chr_fe_write(s->chr, &ch, 1); + qemu_chr_fe_write_all(s->chr, &ch, 1); } s->regs[R_STAT] |= STAT_TX_EVT; break; -- 1.7.10.4