From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmKcH-0007Fe-Do for qemu-devel@nongnu.org; Fri, 29 Nov 2013 04:44:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmKc6-0000mX-2t for qemu-devel@nongnu.org; Fri, 29 Nov 2013 04:44:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmKc5-0000lV-RT for qemu-devel@nongnu.org; Fri, 29 Nov 2013 04:43:54 -0500 From: armbru@redhat.com Date: Fri, 29 Nov 2013 10:43:43 +0100 Message-Id: <1385718225-26379-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 0/2] Pointer properties and device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, marcel.a@redhat.com, chouteau@adacore.com, blauwirbel@gmail.com, kraxel@redhat.com, aliguori@amazon.com, edgar.iglesias@gmail.com, afaerber@suse.de From: Markus Armbruster Pointer properties can be set only by code, not by device_add. A device with a pointer property can't work with device_add only unless the property may remain null. cannot_instantiate_with_device_add_yet needs to be set then. PATCH 1/2 sets it when needed and else documents why not. PATCH 2/2 documents this for future users of pointer properties. This applies on top of my "[PATCH v4 00/10] Clean up and fix no_user" series. Markus Armbruster (2): hw: cannot_instantiate_with_device_add_yet due to pointer props qdev: Document that pointer properties kill device_add hw/audio/marvell_88w8618.c | 2 ++ hw/dma/sparc32_dma.c | 2 ++ hw/gpio/omap_gpio.c | 4 ++++ hw/i2c/omap_i2c.c | 2 ++ hw/i2c/smbus_eeprom.c | 2 ++ hw/intc/etraxfs_pic.c | 4 ++++ hw/intc/grlib_irqmp.c | 2 ++ hw/intc/omap_intc.c | 4 ++++ hw/net/etraxfs_eth.c | 2 ++ hw/net/lance.c | 2 ++ include/hw/qdev-properties.h | 17 +++++++++++++++++ 11 files changed, 43 insertions(+) -- 1.8.1.4