qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, afaerber@suse.de, mst@redhat.com
Subject: [Qemu-devel] [PATCH 07/30] virtio-serial: switch exit callback to VirtioDeviceClass
Date: Fri, 29 Nov 2013 11:17:19 +0100	[thread overview]
Message-ID: <1385720262-14107-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1385720262-14107-1-git-send-email-pbonzini@redhat.com>

This ensures hot-unplug is handled properly by the proxy.

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/char/virtio-serial-bus.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 703f026..a7ede90 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -987,12 +987,11 @@ static const TypeInfo virtio_serial_port_type_info = {
     .class_init = virtio_serial_port_class_init,
 };
 
-static int virtio_serial_device_exit(DeviceState *dev)
+static void virtio_serial_device_exit(VirtIODevice *vdev)
 {
-    VirtIOSerial *vser = VIRTIO_SERIAL(dev);
-    VirtIODevice *vdev = VIRTIO_DEVICE(dev);
+    VirtIOSerial *vser = VIRTIO_SERIAL(vdev);
 
-    unregister_savevm(dev, "virtio-console", vser);
+    unregister_savevm(DEVICE(vdev), "virtio-console", vser);
 
     g_free(vser->ivqs);
     g_free(vser->ovqs);
@@ -1004,7 +1003,6 @@ static int virtio_serial_device_exit(DeviceState *dev)
         g_free(vser->post_load);
     }
     virtio_cleanup(vdev);
-    return 0;
 }
 
 static Property virtio_serial_properties[] = {
@@ -1016,10 +1014,10 @@ static void virtio_serial_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
-    dc->exit = virtio_serial_device_exit;
     dc->props = virtio_serial_properties;
     set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
     vdc->init = virtio_serial_device_init;
+    vdc->exit = virtio_serial_device_exit;
     vdc->get_features = get_features;
     vdc->get_config = get_config;
     vdc->set_config = set_config;
-- 
1.8.3.1

  parent reply	other threads:[~2013-11-29 10:18 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 10:17 [Qemu-devel] [PATCH v4 00/30] virtio: cleanup, fix hot-unplug, move to realize Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 01/30] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 02/30] virtio-bus: remove vdev field Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 03/30] virtio-ccw: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 04/30] virtio-pci: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 05/30] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 06/30] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-11-29 10:17 ` Paolo Bonzini [this message]
2013-11-29 10:17 ` [Qemu-devel] [PATCH 08/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 09/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 10/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 11/30] virtio-rng: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 12/30] virtio-pci: add device_unplugged callback Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 13/30] virtio-blk-dataplane: Improve error reporting Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 14/30] virtio-9p: QOM realize preparations Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 15/30] virtio-blk: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 16/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 17/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 18/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 19/30] virtio-rng: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 20/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 21/30] virtio: Start converting VirtioDevice to QOM realize Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 22/30] virtio-9p: Convert " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 23/30] virtio-blk: " Paolo Bonzini
2013-11-29 16:08   ` Andreas Färber
2013-11-29 10:17 ` [Qemu-devel] [PATCH 24/30] virtio-serial: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 25/30] virtio-net: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 26/30] virtio-balloon: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 27/30] virtio-rng: " Paolo Bonzini
2013-11-29 16:10   ` Andreas Färber
2013-11-29 16:12     ` Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 28/30] virtio-scsi: " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 29/30] virtio: Complete converting VirtioDevice " Paolo Bonzini
2013-11-29 10:17 ` [Qemu-devel] [PATCH 30/30] virtio: Convert exit to unrealize Paolo Bonzini
2013-12-07  1:46 ` [Qemu-devel] [PATCH v4 00/30] virtio: cleanup, fix hot-unplug, move to realize Andreas Färber
2013-12-09 17:57 ` Paolo Bonzini
2013-12-09 18:52   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385720262-14107-8-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).