qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 13/41] iscsi: add bdrv_co_write_zeroes
Date: Fri, 29 Nov 2013 17:45:28 +0100	[thread overview]
Message-ID: <1385743555-27888-14-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1385743555-27888-1-git-send-email-kwolf@redhat.com>

From: Peter Lieven <pl@kamp.de>

Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/iscsi.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/block/iscsi.c b/block/iscsi.c
index f91134e..b7b5238 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -56,6 +56,7 @@ typedef struct IscsiLun {
     uint8_t lbprz;
     struct scsi_inquiry_logical_block_provisioning lbp;
     struct scsi_inquiry_block_limits bl;
+    unsigned char *zeroblock;
 } IscsiLun;
 
 typedef struct IscsiTask {
@@ -959,6 +960,65 @@ retry:
     return 0;
 }
 
+#if defined(SCSI_SENSE_ASCQ_CAPACITY_DATA_HAS_CHANGED)
+
+static int
+coroutine_fn iscsi_co_write_zeroes(BlockDriverState *bs, int64_t sector_num,
+                                   int nb_sectors, BdrvRequestFlags flags)
+{
+    IscsiLun *iscsilun = bs->opaque;
+    struct IscsiTask iTask;
+    uint64_t lba;
+    uint32_t nb_blocks;
+
+    if (!is_request_lun_aligned(sector_num, nb_sectors, iscsilun)) {
+        return -EINVAL;
+    }
+
+    if (!iscsilun->lbp.lbpws) {
+        /* WRITE SAME is not supported by the target */
+        return -ENOTSUP;
+    }
+
+    lba = sector_qemu2lun(sector_num, iscsilun);
+    nb_blocks = sector_qemu2lun(nb_sectors, iscsilun);
+
+    if (iscsilun->zeroblock == NULL) {
+        iscsilun->zeroblock = g_malloc0(iscsilun->block_size);
+    }
+
+    iscsi_co_init_iscsitask(iscsilun, &iTask);
+retry:
+    if (iscsi_writesame16_task(iscsilun->iscsi, iscsilun->lun, lba,
+                               iscsilun->zeroblock, iscsilun->block_size,
+                               nb_blocks, 0, !!(flags & BDRV_REQ_MAY_UNMAP),
+                               0, 0, iscsi_co_generic_cb, &iTask) == NULL) {
+        return -EIO;
+    }
+
+    while (!iTask.complete) {
+        iscsi_set_events(iscsilun);
+        qemu_coroutine_yield();
+    }
+
+    if (iTask.task != NULL) {
+        scsi_free_scsi_task(iTask.task);
+        iTask.task = NULL;
+    }
+
+    if (iTask.do_retry) {
+        goto retry;
+    }
+
+    if (iTask.status != SCSI_STATUS_GOOD) {
+        return -EIO;
+    }
+
+    return 0;
+}
+
+#endif /* SCSI_SENSE_ASCQ_CAPACITY_DATA_HAS_CHANGED */
+
 static int parse_chap(struct iscsi_context *iscsi, const char *target)
 {
     QemuOptsList *list;
@@ -1421,6 +1481,7 @@ static void iscsi_close(BlockDriverState *bs)
     }
     qemu_aio_set_fd_handler(iscsi_get_fd(iscsi), NULL, NULL, NULL);
     iscsi_destroy_context(iscsi);
+    g_free(iscsilun->zeroblock);
     memset(iscsilun, 0, sizeof(IscsiLun));
 }
 
@@ -1539,6 +1600,9 @@ static BlockDriver bdrv_iscsi = {
     .bdrv_co_get_block_status = iscsi_co_get_block_status,
 #endif
     .bdrv_co_discard      = iscsi_co_discard,
+#if defined(SCSI_SENSE_ASCQ_CAPACITY_DATA_HAS_CHANGED)
+    .bdrv_co_write_zeroes = iscsi_co_write_zeroes,
+#endif
 
     .bdrv_aio_readv  = iscsi_aio_readv,
     .bdrv_aio_writev = iscsi_aio_writev,
-- 
1.8.1.4

  parent reply	other threads:[~2013-11-29 16:46 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 16:45 [Qemu-devel] [PULL 00/41] Block patches for 2.0 (flushing block-next) Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 01/41] block: make BdrvRequestFlags public Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 02/41] block: add flags to bdrv_*_write_zeroes Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 03/41] block: introduce BDRV_REQ_MAY_UNMAP request flag Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 04/41] block: add logical block provisioning info to BlockDriverInfo Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 05/41] block: add wrappers for logical block provisioning information Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 06/41] block/iscsi: add .bdrv_get_info Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 07/41] block: add BlockLimits structure to BlockDriverState Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 08/41] block/raw: copy BlockLimits on raw_open Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 09/41] block: honour BlockLimits in bdrv_co_do_write_zeroes Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 10/41] block: honour BlockLimits in bdrv_co_discard Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 11/41] iscsi: set limits in BlockDriverState Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 12/41] iscsi: simplify iscsi_co_discard Kevin Wolf
2013-11-29 16:45 ` Kevin Wolf [this message]
2013-11-29 16:45 ` [Qemu-devel] [PULL 14/41] block: introduce bdrv_make_zero Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 15/41] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 16/41] qemu-img: add support for fully allocated images Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 17/41] qemu-img: conditionally zero out target on convert Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 18/41] util/error: Save errno from clobbering Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 19/41] Test coroutine execution order Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 20/41] sheepdog: implement .bdrv_get_allocated_file_size Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 21/41] block/stream: Don't stream unbacked devices Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 22/41] block: per caller dirty bitmap Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 23/41] qapi: Change BlockDirtyInfo to list Kevin Wolf
2013-11-30 20:38   ` Eric Blake
2013-12-02 10:29     ` Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 24/41] COW: Speed up writes Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 25/41] COW: Extend checking allocated bits to beyond one sector Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 26/41] MAINTAINERS: add sheepdog development mailing list Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 27/41] qdict: Fix memory leak in qdict_do_flatten() Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 28/41] qdict: Optimise qdict_do_flatten() Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 29/41] sheepdog: refactor do_sd_create() Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 30/41] sheepdog: support user-defined redundancy option Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 31/41] qemu-iotests: Drop local version of cancel_and_wait from 040 Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 32/41] blkdebug: add "remove_break" command Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 33/41] qemu-iotest: Add pause_drive and resume_drive methods Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 34/41] qemu-iotests: Make test case 030, 040 and 055 deterministic Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 35/41] block: Enable BDRV_O_SNAPSHOT with driver-specific options Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 36/41] qemu-iotests: Test snapshot mode Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 37/41] block: Use BDRV_O_NO_BACKING where appropriate Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 38/41] qemu-iotests: Filter qemu-io output in 025 Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 40/41] vmdk: Allow read only open of VMDK version 3 Kevin Wolf
2013-11-29 16:45 ` [Qemu-devel] [PULL 41/41] qemu-iotests: Add sample image and test for " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385743555-27888-14-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).