From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmRDw-0005Bn-VZ for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:47:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmRDr-00034Q-0L for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:47:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmRDq-00034I-OG for qemu-devel@nongnu.org; Fri, 29 Nov 2013 11:47:18 -0500 From: Kevin Wolf Date: Fri, 29 Nov 2013 17:45:54 +0100 Message-Id: <1385743555-27888-40-git-send-email-kwolf@redhat.com> In-Reply-To: <1385743555-27888-1-git-send-email-kwolf@redhat.com> References: <1385743555-27888-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 40/41] vmdk: Allow read only open of VMDK version 3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/vmdk.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5fb6c81..88d09e3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -605,13 +605,20 @@ static int vmdk_open_vmdk4(BlockDriverState *bs, header = footer.header; } - if (le32_to_cpu(header.version) >= 3) { + if (le32_to_cpu(header.version) > 3) { char buf[64]; snprintf(buf, sizeof(buf), "VMDK version %d", le32_to_cpu(header.version)); qerror_report(QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, bs->device_name, "vmdk", buf); return -ENOTSUP; + } else if (le32_to_cpu(header.version) == 3 && (flags & BDRV_O_RDWR)) { + /* VMware KB 2064959 explains that version 3 added support for + * persistent changed block tracking (CBT), and backup software can + * read it as version=1 if it doesn't care about the changed area + * information. So we are safe to enable read only. */ + error_setg(errp, "VMDK version 3 must be read only"); + return -EINVAL; } if (le32_to_cpu(header.num_gtes_per_gt) > 512) { -- 1.8.1.4