From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 1/4] i440fx-test: qtest_start() should be paired with qtest_end()
Date: Fri, 29 Nov 2013 18:12:19 +0100 [thread overview]
Message-ID: <1385745142-20520-2-git-send-email-lersek@redhat.com> (raw)
In-Reply-To: <1385745142-20520-1-git-send-email-lersek@redhat.com>
Similarly to commit 1d9358e6
("libqtest: New qtest_end() to go with qtest_start()").
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
tests/i440fx-test.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
index 65c786c..6ac46bf 100644
--- a/tests/i440fx-test.c
+++ b/tests/i440fx-test.c
@@ -2,9 +2,11 @@
* qtest I440FX test case
*
* Copyright IBM, Corp. 2012-2013
+ * Copyright Red Hat, Inc. 2013
*
* Authors:
* Anthony Liguori <aliguori@us.ibm.com>
+ * Laszlo Ersek <lersek@redhat.com>
*
* This work is licensed under the terms of the GNU GPL, version 2 or later.
* See the COPYING file in the top-level directory.
@@ -256,7 +258,6 @@ static void test_i440fx_pam(gconstpointer opaque)
int main(int argc, char **argv)
{
- QTestState *s;
TestData data;
char *cmdline;
int ret;
@@ -266,20 +267,17 @@ int main(int argc, char **argv)
data.num_cpus = 1;
cmdline = g_strdup_printf("-smp %d", data.num_cpus);
- s = qtest_start(cmdline);
+ qtest_start(cmdline);
g_free(cmdline);
data.bus = qpci_init_pc();
g_test_add_data_func("/i440fx/defaults", &data, test_i440fx_defaults);
g_test_add_data_func("/i440fx/pam", &data, test_i440fx_pam);
-
ret = g_test_run();
- if (s) {
- qtest_quit(s);
- }
+ qtest_end();
return ret;
}
--
1.8.3.1
next prev parent reply other threads:[~2013-11-29 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 17:12 [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility Laszlo Ersek
2013-11-29 17:12 ` Laszlo Ersek [this message]
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 2/4] i440fx-test: give each GTest case its own qtest Laszlo Ersek
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 3/4] i440fx-test: generate temporary firmware blob Laszlo Ersek
2013-11-29 17:12 ` [Qemu-devel] [PATCH v3 4/4] i440fx-test: verify firmware under 4G and 1M, both -bios and -pflash Laszlo Ersek
2013-12-09 17:53 ` [Qemu-devel] [PATCH v3 0/4] i440fx-test: check firmware visibility Paolo Bonzini
2013-12-16 16:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385745142-20520-2-git-send-email-lersek@redhat.com \
--to=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).