From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vn6qg-0007M8-L5 for qemu-devel@nongnu.org; Sun, 01 Dec 2013 08:14:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vn6qa-0006jR-MG for qemu-devel@nongnu.org; Sun, 01 Dec 2013 08:14:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vn6qa-0006jN-D3 for qemu-devel@nongnu.org; Sun, 01 Dec 2013 08:14:04 -0500 Message-ID: <1385903630.23603.7.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Sun, 01 Dec 2013 15:13:50 +0200 In-Reply-To: <1385718225-26379-1-git-send-email-armbru@redhat.com> References: <1385718225-26379-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Pointer properties and device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, chouteau@adacore.com, blauwirbel@gmail.com, kraxel@redhat.com, aliguori@amazon.com, edgar.iglesias@gmail.com, afaerber@suse.de On Fri, 2013-11-29 at 10:43 +0100, armbru@redhat.com wrote: > From: Markus Armbruster > > Pointer properties can be set only by code, not by device_add. A > device with a pointer property can't work with device_add only unless > the property may remain null. cannot_instantiate_with_device_add_yet > needs to be set then. PATCH 1/2 sets it when needed and else > documents why not. PATCH 2/2 documents this for future users of > pointer properties. > > This applies on top of my "[PATCH v4 00/10] Clean up and fix no_user" > series. Even that I am not familiar with this code, I've checked all the changes and I agree with them. Reviewed-by: Marcel Apfelbaum Anyway, I do have a question: Why not asserting on qdev_device_add if we have a pointer property? Instead of checking only cannot_instantiate_with_device_add_yet, we can go over properties and if we have a pointer property, assert or return... Thanks, Marcel > > Markus Armbruster (2): > hw: cannot_instantiate_with_device_add_yet due to pointer props > qdev: Document that pointer properties kill device_add > > hw/audio/marvell_88w8618.c | 2 ++ > hw/dma/sparc32_dma.c | 2 ++ > hw/gpio/omap_gpio.c | 4 ++++ > hw/i2c/omap_i2c.c | 2 ++ > hw/i2c/smbus_eeprom.c | 2 ++ > hw/intc/etraxfs_pic.c | 4 ++++ > hw/intc/grlib_irqmp.c | 2 ++ > hw/intc/omap_intc.c | 4 ++++ > hw/net/etraxfs_eth.c | 2 ++ > hw/net/lance.c | 2 ++ > include/hw/qdev-properties.h | 17 +++++++++++++++++ > 11 files changed, 43 insertions(+) >