From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnUND-0003dX-P8 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 09:21:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnUN8-0007bQ-NW for qemu-devel@nongnu.org; Mon, 02 Dec 2013 09:21:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnUN8-0007bI-G7 for qemu-devel@nongnu.org; Mon, 02 Dec 2013 09:21:14 -0500 From: Marcel Apfelbaum Date: Mon, 2 Dec 2013 16:20:59 +0200 Message-Id: <1385994059-16812-1-git-send-email-marcel.a@redhat.com> Subject: [Qemu-devel] [PATCH] memory.c: bugfix - ref counting mismatch in memory_region_find List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, jan.kiszka@siemens.com, anthony@codemonkey.ws, pbonzini@redhat.com, rth@twiddle.net 'address_space_get_flatview' gets a reference to a FlatView. If the flatview lookup fails, the code returns without "unreferencing" the view. Cc: qemu-stable@nongnu.org Signed-off-by: Marcel Apfelbaum --- memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/memory.c b/memory.c index 28f6449..7764314 100644 --- a/memory.c +++ b/memory.c @@ -1596,6 +1596,7 @@ MemoryRegionSection memory_region_find(MemoryRegion *mr, view = address_space_get_flatview(as); fr = flatview_lookup(view, range); if (!fr) { + flatview_unref(view); return ret; } -- 1.8.3.1