From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Vnl4n-00013g-F5
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:11:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Vnl4h-0003cL-FU
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:11:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55396)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Vnl4g-0003cH-U9
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:11:19 -0500
Message-ID: <1386058273.13307.8.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 03 Dec 2013 09:11:13 +0100
In-Reply-To: <529CDBB0.5030100@redhat.com>
References: <1385649010-7034-1-git-send-email-kraxel@redhat.com>
	<1385649010-7034-4-git-send-email-kraxel@redhat.com>
	<529CDBB0.5030100@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 03/15] input: define event types using
	qapi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, Dave Airlie <airlied@gmail.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Mo, 2013-12-02 at 12:12 -0700, Eric Blake wrote:
> On 11/28/2013 07:29 AM, Gerd Hoffmann wrote:
> > Define input event types, using qapi.  So we get nicely autogenerated
> > types for our input events.  And when it comes to qmp support some day
> > things will be alot easier.
> > 
> > Types are modeled after the linux input layer.  There are separate
> > event types for each value.  There is a sync to indicate the end
> > of a event group.
> > 
> > Mouse events are splitted into motion events (one for each axis) and
> 
> s/splitted/split/ (yes, one of those stupid English words whose
> past-tense spelling is the same as its present tense)

Thanks for the explanation.  That hopefully makes it a bit easier to
remember.

> > +###########################################################
> > +# WIP - input event data structures
> > +# not exposed via qmp yet, needs testing first
> 
> But still worth documenting, and adding "Since 2.0" annotations to each
> enum and struct.

Sure, already on the todo list for the final patch version.

cheers,
  Gerd