From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vnlof-0006zH-Ke for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnloY-0001y6-RJ for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:58:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnloY-0001y1-Ip for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:58:42 -0500 Message-ID: <1386061117.13307.14.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 03 Dec 2013 09:58:37 +0100 In-Reply-To: <529CD8EB.5030403@spineless.org> References: <1385649010-7034-1-git-send-email-kraxel@redhat.com> <1385649010-7034-12-git-send-email-kraxel@redhat.com> <529CD8EB.5030403@spineless.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Baboval Cc: qemu-devel@nongnu.org On Mo, 2013-12-02 at 14:00 -0500, John Baboval wrote: > I'm not sure this is correct. Generally when the display gets rotated, > the input device coordinates do not, and the in-guest code handles the math. This just mimics what kbd_mouse_event() does today. I guess there is a reason this code was added. I suspect it's some embedded target which depend on this stuff. Anyone knows? cheers, Gerd