From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.crosthwaite@xilinx.com, hpoussin@reactos.org, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 0/2] qom: fix registration of QOM interfaces
Date: Tue, 3 Dec 2013 16:41:58 +0100 [thread overview]
Message-ID: <1386085320-12965-1-git-send-email-pbonzini@redhat.com> (raw)
object_class_foreach can initialize new types, and also register new types
corresponding to the implementations of interfaces. Those will change the
type internal hashtable which is currently enumerated, and GHashTable does
not permit this.
Fix this by not registering those internal types in the hash table, and
assert that we do not reenter GHashTable incorrectly during iteration.
Hervé Poussineau (1):
qom: detect bad reentrance during object_class_foreach
Paolo Bonzini (1):
qom: do not register interface "types" in the type table
qom/object.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
--
1.8.4.2
next reply other threads:[~2013-12-03 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 15:41 Paolo Bonzini [this message]
2013-12-03 15:41 ` [Qemu-devel] [PATCH 1/2] qom: do not register interface "types" in the type table Paolo Bonzini
2013-12-03 15:42 ` [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach Paolo Bonzini
2013-12-04 5:51 ` Peter Crosthwaite
2013-12-15 21:23 ` Andreas Färber
2013-12-19 11:38 ` Alexey Kardashevskiy
2013-12-20 11:29 ` Andreas Färber
2013-12-20 11:43 ` Alexey Kardashevskiy
2013-12-24 6:49 ` Alexey Kardashevskiy
2013-12-24 11:20 ` Andreas Färber
2013-12-15 21:25 ` [Qemu-devel] [PATCH 0/2] qom: fix registration of QOM interfaces Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386085320-12965-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=hpoussin@reactos.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).