From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoDY8-0002Xe-J8 for qemu-devel@nongnu.org; Wed, 04 Dec 2013 09:35:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoDXh-0003E4-VO for qemu-devel@nongnu.org; Wed, 04 Dec 2013 09:35:35 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:33334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoDXh-0003DT-Ot for qemu-devel@nongnu.org; Wed, 04 Dec 2013 09:35:09 -0500 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Dec 2013 07:35:09 -0700 From: Michael Roth Date: Wed, 4 Dec 2013 08:34:35 -0600 Message-Id: <1386167679-13021-29-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1386167679-13021-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1386167679-13021-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 28/32] qom: Fix memory leak in object_property_set_link() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Vlad Yasevich Save the result of the call to object_get_canonical_path() so we can free it. Cc: qemu-stable@nongnu.org Signed-off-by: Vlad Yasevich Reviewed-by: Amos Kong Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber (cherry picked from commit 2d3aa28cc2cf382aa04cd577e0be542175eea9bd) Signed-off-by: Michael Roth --- qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index b2479d1..333f807 100644 --- a/qom/object.c +++ b/qom/object.c @@ -823,8 +823,9 @@ char *object_property_get_str(Object *obj, const char *name, void object_property_set_link(Object *obj, Object *value, const char *name, Error **errp) { - object_property_set_str(obj, object_get_canonical_path(value), - name, errp); + gchar *path = object_get_canonical_path(value); + object_property_set_str(obj, path, name, errp); + g_free(path); } Object *object_property_get_link(Object *obj, const char *name, -- 1.7.9.5